Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2094653003:
fix padding problem by allow horizontal resizing on the cell for the multi line label (Closed)
|
Created:
4 years, 6 months ago by ftang Modified:
4 years, 5 months ago Reviewers:
groby-ooo-7-16 CC:
chromium-reviews, tfarina Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionfix the right padding problem of multiline text ("Do you want google to translate this page from LANG1 to LANG2") on Linux by allow horizontal resizing on the cell for the multi line label. See the problem screenshot on https://bugs.chromium.org/p/chromium/issues/detail?id=622327
BUG=622327
Committed: https://crrev.com/c4a16169021b1cc0c160d064ae6dfd0561a3e6b9
Cr-Commit-Position: refs/heads/master@{#401928}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
The CQ bit was checked by ftang@chromium.org to run a CQ dry run
ftang@chromium.org changed reviewers: + groby@chromium.org
a simple one line fix
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2094653003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/06/24 01:21:30, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. SGTM, but you need Views OWNER. Also, please make the description a bit more descriptive - which padding problem? What particular label? (And ideally, add a screenshot via imgur or something)
On 2016/06/24 18:28:05, groby wrote: > On 2016/06/24 01:21:30, commit-bot: I haz the power wrote: > > Dry run: This issue passed the CQ dry run. > > SGTM, but you need Views OWNER. Also, please make the description a bit more > descriptive - which padding problem? What particular label? (And ideally, add a > screenshot via imgur or something) Never mind, I'm views/translate OWNER, as you pointed out. Sorry, and LGTM - please fix description before landing.
The CQ bit was checked by ftang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ftang@chromium.org
Description was changed from
==========
fix padding problem by allow horizontal resizing on the cell for the multi line
label
BUG=622327
==========
to
==========
fix the right padding problem of multiline text ("Do you want google to
translate this page from LANG1 to LANG2") on Linux by allow horizontal resizing
on the cell for the multi line label
BUG=622327
==========
Description was changed from
==========
fix the right padding problem of multiline text ("Do you want google to
translate this page from LANG1 to LANG2") on Linux by allow horizontal resizing
on the cell for the multi line label
BUG=622327
==========
to
==========
fix the right padding problem of multiline text ("Do you want google to
translate this page from LANG1 to LANG2") on Linux by allow horizontal resizing
on the cell for the multi line label. See the problem screenshot on
https://bugs.chromium.org/p/chromium/issues/detail?id=622327
BUG=622327
==========
The CQ bit was checked by ftang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
fix the right padding problem of multiline text ("Do you want google to
translate this page from LANG1 to LANG2") on Linux by allow horizontal resizing
on the cell for the multi line label. See the problem screenshot on
https://bugs.chromium.org/p/chromium/issues/detail?id=622327
BUG=622327
==========
to
==========
fix the right padding problem of multiline text ("Do you want google to
translate this page from LANG1 to LANG2") on Linux by allow horizontal resizing
on the cell for the multi line label. See the problem screenshot on
https://bugs.chromium.org/p/chromium/issues/detail?id=622327
BUG=622327
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
fix the right padding problem of multiline text ("Do you want google to
translate this page from LANG1 to LANG2") on Linux by allow horizontal resizing
on the cell for the multi line label. See the problem screenshot on
https://bugs.chromium.org/p/chromium/issues/detail?id=622327
BUG=622327
==========
to
==========
fix the right padding problem of multiline text ("Do you want google to
translate this page from LANG1 to LANG2") on Linux by allow horizontal resizing
on the cell for the multi line label. See the problem screenshot on
https://bugs.chromium.org/p/chromium/issues/detail?id=622327
BUG=622327
Committed: https://crrev.com/c4a16169021b1cc0c160d064ae6dfd0561a3e6b9
Cr-Commit-Position: refs/heads/master@{#401928}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c4a16169021b1cc0c160d064ae6dfd0561a3e6b9 Cr-Commit-Position: refs/heads/master@{#401928} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
