Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h

Issue 2094633003: Bluetooth: Mac: implementation for start notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@write_read_characteristicscan_servicescan_cleanup
Patch Set: Addressing msarda's comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h
index 4db6bacd82fb4f4843fb29b0d5d55a1f59e7ea18..9fabee489170db9ed12a97df1c747e49a1a9200e 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h
@@ -8,6 +8,7 @@
#include "device/bluetooth/bluetooth_remote_gatt_characteristic.h"
#include "base/mac/scoped_nsobject.h"
+#include "base/memory/weak_ptr.h"
#if defined(__OBJC__)
#import <CoreBluetooth/CoreBluetooth.h>
@@ -60,13 +61,20 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattCharacteristicMac
// Called by the BluetoothRemoteGattServiceMac instance when the
// characteristics value has been read.
void DidUpdateValue(NSError* error);
+ // Updates value_ and notifies the adapter of the new value.
+ void UpdateValueAndNotify();
// Called by the BluetoothRemoteGattServiceMac instance when the
// characteristics value has been written.
void DidWriteValue(NSError* error);
+ // Called by the BluetoothRemoteGattServiceMac instance when the notify
+ // session has been started or failed to be started.
+ void DidUpdateNotificationState(NSError* error);
// Returns true if the characteristic is readable.
bool IsReadable() const;
// Returns true if the characteristic is writable.
bool IsWritable() const;
+ // Returns true if the characteristic supports notifications or indications.
+ bool SupportsNotificationsOrIndications() const;
// Returns the write type (with or without responses).
CBCharacteristicWriteType GetCBWriteType() const;
// Returns CoreBluetooth characteristic.
@@ -88,6 +96,13 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattCharacteristicMac
std::pair<ValueCallback, ErrorCallback> read_characteristic_value_callbacks_;
// WriteRemoteCharacteristic request callbacks.
std::pair<base::Closure, ErrorCallback> write_characteristic_value_callbacks_;
+ // Stores StartNotifySession request callbacks.
+ typedef std::pair<NotifySessionCallback, ErrorCallback>
+ PendingStartNotifyCall;
+ std::vector<PendingStartNotifyCall> start_notify_session_callbacks_;
+ // Flag indicates if GATT event registration is in progress.
+ bool start_notifications_in_progress_;
+ base::WeakPtrFactory<BluetoothRemoteGattCharacteristicMac> weak_ptr_factory_;
};
} // namespace device

Powered by Google App Engine
This is Rietveld 408576698