Bluetooth: Mac: implementation for start notification

device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_MAC_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_MAC_H_
 
 #include "device/bluetooth/bluetooth_remote_gatt_characteristic.h"
 
 #include "base/mac/scoped_nsobject.h"
+#include "base/memory/weak_ptr.h"
 
 #if defined(__OBJC__)
 #import <CoreBluetooth/CoreBluetooth.h>
 #else
 @class CBCharacteristic;
 typedef NS_ENUM(NSInteger, CBCharacteristicWriteType);
 #endif  // defined(__OBJC__)
 
 namespace device {
 
@@ skipping 32 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothRemoteGattCharacteristicMac);
 
  private:
   friend class BluetoothRemoteGattServiceMac;
   friend class BluetoothTestMac;
 
   // Called by the BluetoothRemoteGattServiceMac instance when the
   // characteristics value has been read.
   void DidUpdateValue(NSError* error);
+  // Updates the |value_| and send notify the mac adapter for the new value

[ortuno, 2016/06/28 16:24:50]

nit: Usually the "|" are used when referring to a function argument.

[jlebel, 2016/06/28 18:09:52]

Done.

+  void UpdateValueAndNotify();
   // Called by the BluetoothRemoteGattServiceMac instance when the
   // characteristics value has been written.
   void DidWriteValue(NSError* error);
+  // Called by the BluetoothRemoteGattServiceMac instance when the notify
+  // session has been started or failed.
+  void DidUpdateNotificationState(NSError* error);
   // Returns true if the characteristic is readable.
   bool IsReadable() const;
   // Returns true if the characteristic is writable.
   bool IsWritable() const;
+  // Returns true if the characteristic is notifiable or indicatable.

[ortuno, 2016/06/28 16:24:49]

nit: ... if the characteristic supports notifications or indications.

[jlebel, 2016/06/28 18:09:52]

Done.

+  bool IsNotifiableOrIndicatable() const;

[ortuno, 2016/06/28 16:24:49]

nit: SupportsNotificationsOrIndications.

[jlebel, 2016/06/28 18:09:52]

Done.

   // Returns the write type (with or without responses).
   CBCharacteristicWriteType GetCBWriteType() const;
   // Returns CoreBluetooth characteristic.
   CBCharacteristic* GetCBCharacteristic() const;
 
   // gatt_service_ owns instances of this class.
   BluetoothRemoteGattServiceMac* gatt_service_;
   // A characteristic from CBPeripheral.services.characteristics.
   base::scoped_nsobject<CBCharacteristic> cb_characteristic_;
   // Characteristic identifier.
   std::string identifier_;
   // Service UUID.
   BluetoothUUID uuid_;
   // Characteristic value.
   std::vector<uint8_t> value_;
   // True if a gatt read or write request is in progress.
   bool characteristic_value_read_or_write_in_progress_;
   // ReadRemoteCharacteristic request callbacks.
   std::pair<ValueCallback, ErrorCallback> read_characteristic_value_callbacks_;
   // WriteRemoteCharacteristic request callbacks.
   std::pair<base::Closure, ErrorCallback> write_characteristic_value_callbacks_;
+  // Vector stores StartNotifySession request callbacks.

[ortuno, 2016/06/28 16:24:49]

nit: Remove "Vector". The type is easy to see already.

[jlebel, 2016/06/28 18:09:52]

Done.

+  std::vector<std::pair<NotifySessionCallback, ErrorCallback>>

[ortuno, 2016/06/28 16:24:49]

nit optional: make the pair a typedef like
https://cs.chromium.org/chromium/src/device/bluetooth/bluetooth_remote_gatt_c...

[jlebel, 2016/06/28 18:09:52]

Done.

+      start_notify_session_callbacks_;
+  // Flag indicates if GATT event registration is in progress.
+  bool gatt_event_registeration_in_progress_;

[ortuno, 2016/06/28 16:24:49]

nit: change this to start_notifications_in_progress or similar. In windows it's
called gatt_event_registration because the API to enable notifications is called
BluetoothGattRegisterEvent.

[jlebel, 2016/06/28 18:09:52]

Done.

+  base::WeakPtrFactory<BluetoothRemoteGattCharacteristicMac> weak_ptr_factory_;
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_MAC_H_