Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: content/ppapi_plugin/ppapi_thread.cc

Issue 2094623002: Use ChannelMojo for plugin-renderer channels. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-ipc-channel-handle
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/pepper/host_dispatcher_wrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/ppapi_plugin/ppapi_thread.cc
diff --git a/content/ppapi_plugin/ppapi_thread.cc b/content/ppapi_plugin/ppapi_thread.cc
index a32122dbfb6b779fc7a540ee6955488e57abb63c..3b8dd6aab464fec09b6d6375047eafb65a52707d 100644
--- a/content/ppapi_plugin/ppapi_thread.cc
+++ b/content/ppapi_plugin/ppapi_thread.cc
@@ -490,9 +490,10 @@ bool PpapiThread::SetupChannel(base::ProcessId renderer_pid,
IPC::ChannelHandle* handle) {
DCHECK(is_broker_ == (connect_instance_func_ != NULL));
IPC::ChannelHandle plugin_handle;
- plugin_handle.name = IPC::Channel::GenerateVerifiedChannelID(
+ IPC::Channel::GenerateMojoChannelHandlePair(
base::StringPrintf(
- "%d.r%d", base::GetCurrentProcId(), renderer_child_id));
+ "plugin-%d.r%d", base::GetCurrentProcId(), renderer_child_id),
+ &plugin_handle, handle);
ppapi::proxy::ProxyChannel* dispatcher = NULL;
bool init_result = false;
@@ -520,20 +521,11 @@ bool PpapiThread::SetupChannel(base::ProcessId renderer_pid,
}
if (!init_result) {
+ handle->mojo_handle.Close();
delete dispatcher;
return false;
}
- handle->name = plugin_handle.name;
-#if defined(OS_POSIX)
- // On POSIX, transfer ownership of the renderer-side (client) FD.
- // This ensures this process will be notified when it is closed even if a
- // connection is not established.
- handle->socket = base::FileDescriptor(dispatcher->TakeRendererFD());
- if (handle->socket.fd == -1)
- return false;
-#endif
-
// From here, the dispatcher will manage its own lifetime according to the
// lifetime of the attached channel.
return true;
« no previous file with comments | « no previous file | content/renderer/pepper/host_dispatcher_wrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698