Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2094613004: Revert of Test262 roll (Closed)

Created:
4 years, 6 months ago by Dan Ehrenberg
Modified:
4 years, 6 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Test262 roll (patchset #15 id:280001 of https://codereview.chromium.org/2068263002/ ) Reason for revert: Broke msan and tsan; need to add an extra skip Original issue's description: > Test262 roll > > This roll does not include a test harness change; infrastructure issues > still need to be worked out. > > Committed: https://crrev.com/d3a95b8a78eefabf884a60bc3d6aac5830b44eb3 > Cr-Commit-Position: refs/heads/master@{#37225} TBR=adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8ea2cbea2e65dc506d50a25a81e610f37bc751ec Cr-Commit-Position: refs/heads/master@{#37226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -264 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M test/test262/test262.status View 9 chunks +37 lines, -263 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Ehrenberg
Created Revert of Test262 roll
4 years, 6 months ago (2016-06-23 19:29:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2094613004/1
4 years, 6 months ago (2016-06-23 19:29:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 19:29:52 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8ea2cbea2e65dc506d50a25a81e610f37bc751ec Cr-Commit-Position: refs/heads/master@{#37226}
4 years, 6 months ago (2016-06-23 19:31:38 UTC) #6
Dan Ehrenberg
4 years, 6 months ago (2016-06-23 19:31:52 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2097573003/ by littledan@chromium.org.

The reason for reverting is: Reland fixing msan and tsan.

Powered by Google App Engine
This is Rietveld 408576698