Canonicalize CheckedSmiOp if compile type turns out to be smi.

Canonicalize CheckedSmiOp if compile type turns out to be smi.

Certain CheckedSmiOp operations can be specialized later during optimization
when the compile type turns out to be smi, and we know that the operation
can't deoptimize.

BUG=#26761
R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/28c0ab16f2f31c2fa21b96d2b5d187986150c264

[Florian Schneider, 2016-06-23 17:15:13]

fschneider@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2016-06-23 17:17:57]

https://codereview.chromium.org/2094613003/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/2094613003/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language.cc:1770: case Token::kBIT_AND:
Please add a comment here about deoptimizations - why bitwise operations are
covered and not anything else.

[Vyacheslav Egorov (Google), 2016-06-23 17:18:02]

lgtm

[Florian Schneider, 2016-06-23 17:31:27]

Description was changed from

==========
Canonicalize CheckedSmiOp if compile type turns out to be smi.

Certain CheckedSmiOp operations can be specialized later during optimization
when the compile type turns out to be smi, and we know that the operation
can't deoptimize.

BUG=#26761
==========

to

==========
Canonicalize CheckedSmiOp if compile type turns out to be smi.

Certain CheckedSmiOp operations can be specialized later during optimization
when the compile type turns out to be smi, and we know that the operation
can't deoptimize.

BUG=#26761
R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/28c0ab16f2f31c2fa21b96d2b5d187986150c264
==========

[Florian Schneider, 2016-06-23 17:31:28]

Committed patchset #2 (id:20001) manually as
28c0ab16f2f31c2fa21b96d2b5d187986150c264 (presubmit successful).

[Florian Schneider, 2016-06-23 17:35:04]

https://codereview.chromium.org/2094613003/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/2094613003/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language.cc:1770: case Token::kBIT_AND:
On 2016/06/23 17:17:57, Vyacheslav Egorov (Google) wrote:
> Please add a comment here about deoptimizations - why bitwise operations are
> covered and not anything else.

Done.