chrome/installer/mac/app/parser.h - Issue 2094583004: Initial commit for Chrome metainstaller on Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/parser.h

Issue 2094583004: Initial commit for Chrome metainstaller on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed all comments except main block comment from elly Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_INSTALLER_MAC_APP_PARSER_H_

	6 #define CHROME_INSTALLER_MAC_APP_PARSER_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 @interface Parser : NSObject<NSXMLParserDelegate> {
	Mark Mentovai 2016/07/11 17:56:17 “Parser” is too generic. How about OmahaXMLParser, “Parser” is too generic. How about OmahaXMLParser, which matches OmahaXMLRequest nicely? Rename the files accordingly (and update the #if guards above).
	11 NSMutableArray* chromeIncompleteDownloadURLs_;

	12 NSString* chromeImageFilename_;

	13 }

	14

	15 - (NSMutableArray*)chromeIncompleteDownloadURLs;

	16

	17 - (NSString*)chromeImageFilename;

	18

	19 // Parses an XML and extracts all the URL's it finds as well as the filename.
	Elly Fong-Jones 2016/07/11 16:15:48 an XML? an XML?
	20 // Adds each URL into the array chromeIncompleteDownloadURLs_.

	21 - (NSArray)parseXML:(NSData)omahaResponseXML error:(NSError**)error;

	22

	23 @end

	24

	25 #endif // CHROME_INSTALLER_MAC_APP_PARSER_H_

OLD	NEW