chrome/installer/mac/app/OmahaCommunication.h - Issue 2094583004: Initial commit for Chrome metainstaller on Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/OmahaCommunication.h

Issue 2094583004: Initial commit for Chrome metainstaller on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed all comments except main block comment from elly Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_INSTALLER_MAC_APP_OMAHACOMMUNICATION_H_

	6 #define CHROME_INSTALLER_MAC_APP_OMAHACOMMUNICATION_H_

	7

	8 #import <Foundation/Foundation.h>
	Mark Mentovai 2016/07/11 17:56:16 Blank line between #includes of <system headers> a Blank line between #includes of <system headers> and "our headers"
	9 #include "NetworkCommunication.h"

	10

	11 typedef void (^OmahaRequestCompletionHandler)(NSData, NSError);

	12

	13 @interface OmahaCommunication : NSObject

	14

	15 @property(nonatomic, copy) NSXMLDocument* requestXMLBody;

	16 @property(nonatomic, copy) NetworkCommunication* sessionHelper;

	17

	18 - (id)init;

	19 - (id)initWithBody:(NSXMLDocument*)xmlBody;

	20

	21 // Sends the request created using the session helper.

	22 - (void)sendRequestWithBlock:(OmahaRequestCompletionHandler)block;

	23

	24 @end

	25

	26 #endif // CHROME_INSTALLER_MAC_APP_OMAHACOMMUNICATION_H_

OLD	NEW