chrome/installer/mac/app/BUILD.gn - Issue 2094583004: Initial commit for Chrome metainstaller on Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/BUILD.gn

Issue 2094583004: Initial commit for Chrome metainstaller on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed all comments except main block comment from elly Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.
	Mark Mentovai 2016/07/11 17:56:16 2016. Make sure all of your new files say 2016. 2016. Make sure all of your new files say 2016.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 executable("downloader") {

	6 sources = [

	7 "DownloadDelegate.m",

	8 "NetworkCommunication.m",

	9 "OmahaCommunication.m",

	10 "OmahaXMLRequest.m",

	11 "SystemInfo.m",

	12 "downloader.m",
	Mark Mentovai 2016/07/11 17:56:16 Downloader.m and Parser.m, capital letters, and re Downloader.m and Parser.m, capital letters, and rename the files and their headers to match. Also, rename systemInfo.m to SystemInfo.m (it’s listed with a capital here but the file’s name has it lowercased.)
	13 "main.m",

	14 "parser.m",

	15 ]

	16 libs = [ "Foundation.framework" ]

	17 }

OLD	NEW