chrome/installer/mac/app/DownloadDelegate.h - Issue 2094583004: Initial commit for Chrome metainstaller on Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/DownloadDelegate.h

Issue 2094583004: Initial commit for Chrome metainstaller on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed majority of comments excluding refactoring for blocks in main. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_INSTALLER_MAC_APP_DOWNLOADDELEGATE_H_

	6 #define CHROME_INSTALLER_MAC_APP_DOWNLOADDELEGATE_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 @interface DownloadDelegate : NSObject <NSURLSessionDownloadDelegate>

	11

	12 @end

	13
	Mark Mentovai 2016/07/07 17:53:48 Definitely run clang-format on this via git cl for Definitely run clang-format on this via git cl format as recommended. This will help with things like the 80-column limit and colon alignment. A couple of other style nits that I see: There are two blank lines in a row here, that’s uncommon. Keep it to one. There also are two blank lines at the end of this file, there shouldn’t be any. You should be consistent with the way that your files are named. I see DownloadDelegate starting with a capital D, but I also see systemInfo with a lowercase s. Starting everything with a capital letter is a more Objective-C way to go, but the Google/Chrome style is to use all lowercase with underscores, like download_delegate and system_info. Since this is an isolated Objective-C project, it’s fine to go with the Objective-C convention, like DownloadDelegate. These are .m files, which is Objective-C with no C++. We may want to use C++ in some or all of them, which would be a change to .mm. We can do this as needed, I’m just mentioning it so that you’re aware.
	14

	15 #endif // CHROME_INSTALLER_MAC_APP_DOWNLOADDELEGATE_H_

	16

	17

OLD	NEW

« no previous file with comments | « chrome/installer/mac/app/BUILD.gn ('k') | chrome/installer/mac/app/DownloadDelegate.m » ('j') | chrome/installer/mac/app/DownloadDelegate.m » ('J')