Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/installer/mac/app/OmahaCommunication.h

Issue 2094583004: Initial commit for Chrome metainstaller on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fully addressed making the .dmg download asynchronously Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_INSTALLER_MAC_APP_OMAHACOMMUNICATION_H_
6 #define CHROME_INSTALLER_MAC_APP_OMAHACOMMUNICATION_H_
7
8 #import <Foundation/Foundation.h>
9 #include "NetworkCommunication.h"
10
11 typedef void (^AfterBlock)(NSData*);
Elly Fong-Jones 2016/07/06 15:22:01 OmahaRequestCompletionHandler?
12
13 @interface OmahaCommunication : NSObject
14
15 @property(nonatomic, copy) NSXMLDocument* requestXMLBody;
16 @property(nonatomic, copy) NetworkCommunication* sessionHelper;
17
18 - (id)init;
19 - (id)initWithBody:(NSXMLDocument*) xmlBody;
20
21 // Creates a new HTTP URL request to Omaha using the NetworkCommunication helper
22 // and adjusts the URLRequest by changing the HTTP Method to "POST", which is
Elly Fong-Jones 2016/07/06 15:22:01 This is an implementation detail. Also, is there a
Anna Zeng 2016/07/07 15:24:53 no, but it's a good idea to be able to verify if t
23 // required to not get an error message.
24 - (NSURLRequest*)createOmahaRequest;
25 // Set how to respond to a response, including error handling and kicking off
26 // the next block of code to run after the asynchronous jump.
Elly Fong-Jones 2016/07/06 15:22:01 what asynchronous jump? This is setting the comple
27 - (void)setResponseHandlingWithBlock:(AfterBlock) block;
28 // Sends the request created using the session helper.
29 - (void)sendRequest;
Elly Fong-Jones 2016/07/06 15:22:01 I would do sendRequestWithCompletionHandler: or so
30
31 @end
32
33 #endif // CHROME_INSTALLER_MAC_APP_OMAHACOMMUNICATION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698