chrome/installer/mac/app/request.h - Issue 2094583004: Initial commit for Chrome metainstaller on Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/request.h

Issue 2094583004: Initial commit for Chrome metainstaller on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #if !defined(__x86_64__)

	6 #error "What are you doing?"
	Elly Fong-Jones 2016/06/24 17:26:02 This error should be more descriptive (and probabl This error should be more descriptive (and probably inside the include guards)
	7 #endif

	8

	9 #ifndef CHROME_INSTALLER_MAC_APP_REQUEST_H_

	10 #define CHROME_INSTALLER_MAC_APP_REQUEST_H_

	11

	12 #import <Foundation/Foundation.h>

	13 #include <mach-o/arch.h>
	Elly Fong-Jones 2016/06/24 17:26:02 The constants defined in that header aren't used i The constants defined in that header aren't used in this header, so we should include it in the implementation file instead of the header.
	14

	15

	16 NSString* getArchitecture(void);
	Elly Fong-Jones 2016/06/24 17:26:02 These belong on a class probably (maybe as static These belong on a class probably (maybe as static methods) instead of as free functions. Elly Fong-Jones 2016/06/24 17:26:02 These functions need explanatory comments too. These functions need explanatory comments too.
	17 NSString *getOSVersion(void);

	18 NSXMLDocument createXMLRequestBody(NSString operatingSystem,

	19 NSString *architecture);

	20 NSURLRequest* createOmahaRequest(NSXMLDocument *requestXMLBody);

	21 NSData* sendRequestAndReceiveResponse(NSURLRequest *request);

	22

	23 #endif // CHROME_INSTALLER_MAC_APP_REQUEST_H_

OLD	NEW