Initial commit for Chrome metainstaller on Mac.

chrome/installer/mac/app/parser.m

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "parser.h"
+
+@implementation Parser
+
+- (id)init {
+  if( self = [super init] ) {

[Elly Fong-Jones, 2016/06/24 17:26:02]

proper style is "if ((self = [super init])) {" for this

+    _chromeDownloadURLs = [[NSMutableArray alloc] init];
+  }
+  return self;
+}
+
+- (void)parseXML:(NSData*)someData {

[Elly Fong-Jones, 2016/06/24 17:26:01]

This probably needs more robust error handling than just NSLog

+  NSData *data = someData;
+  NSXMLParser *parser = [[NSXMLParser alloc] initWithData:data];
+  [parser setDelegate:self];
+  bool success = [parser parse];
+  if (!success) {
+    NSError *err = [parser parserError];
+    NSLog(@"%@",err);
+  }
+}
+
+- (void)appendFilenameToURL {

[Elly Fong-Jones, 2016/06/24 17:26:02]

This definitely needs an explanatory comment.

+  int count = [_chromeDownloadURLs count];
+  for (int i = 0; i < count; i++) {
+    NSString *fullFilename = [[_chromeDownloadURLs objectAtIndex:i]
+                              stringByAppendingString: _filename];
+    [_chromeDownloadURLs replaceObjectAtIndex:i withObject: fullFilename];
+  }
+}
+
+- (void)parser:(NSXMLParser *)parser

[Elly Fong-Jones, 2016/06/24 17:26:02]

This should have a comment remarking that it's part of XMLParserDelegate

+    didStartElement:(NSString *)elementName
+       namespaceURI:(NSString *)namespaceURI
+      qualifiedName:(NSString *)qName
+         attributes:(NSDictionary *)attributeDict {
+  if ([elementName isEqualToString:@"url"]) {
+    NSString *extractedURL = [attributeDict objectForKey:@"codebase"];
+    [_chromeDownloadURLs addObject: extractedURL];
+  }
+  if ([elementName isEqualToString:@"package"]) {
+    _filename = [attributeDict objectForKey:@"name"];
+  }
+}
+
+@end