chrome/installer/mac/app/downloader.h - Issue 2094583004: Initial commit for Chrome metainstaller on Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/downloader.h

Issue 2094583004: Initial commit for Chrome metainstaller on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_INSTALLER_MAC_APP_DOWNLOADER_H_

	6 #define CHROME_INSTALLER_MAC_APP_DOWNLOADER_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 NSURL* getChromeImageURL(NSData*);
	Elly Fong-Jones 2016/06/24 17:26:01 These functions should have comments describing wh These functions should have comments describing what they do and names for their parameters. Also, it might be best if these were all part of a Downloader class, which could handle all the steps here together.
	11 NSData* downloadChromeAsData(NSURL*);

	12 NSString* getDownloadsFilePath();

	13 void writeDataToDisk(NSData*);
	Elly Fong-Jones 2016/06/24 17:26:01 This name needs to be longer and more descriptive, This name needs to be longer and more descriptive, specifically about what the data is and where it gets written. Perhaps something like 'writeChromeImageToDownloadsDirectory'? Although that kind of function sort of suggests that a class might be better here.
	14

	15 #endif // CHROME_INSTALLER_MAC_APP_DOWNLOADER_H_

OLD	NEW