components/memory_coordinator/browser/memory_coordinator_impl.cc - Issue 2094583002: Add MemoryCoordinator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/memory_coordinator/browser/memory_coordinator_impl.cc

Issue 2094583002: Add MemoryCoordinator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/memory_coordinator/browser/memory_coordinator_impl.h"

	6

	7 namespace memory_coordinator {

	8

	9 MemoryCoordinatorImpl::MemoryCoordinatorImpl() {}

	10

	11 MemoryCoordinatorImpl::~MemoryCoordinatorImpl() {}

	12

	13 void MemoryCoordinatorImpl::RendererLaunched(

	14 shell::InterfaceProvider* remote_interfaces) {

	15 mojom::ChildMemoryCoordinatorPtr child;

	16 remote_interfaces->GetInterface(mojo::GetProxy(&child));

	17 children_.AddPtr(std::move(child));
	haraken 2016/07/08 02:40:25 Don't we need to remove the pointer when the rende Don't we need to remove the pointer when the renderer is gone? bashi 2016/07/08 02:44:49 No. InterfacePtrSet removes it when an error occur Show quoted text On 2016/07/08 02:40:25, haraken wrote: > > Don't we need to remove the pointer when the renderer is gone? No. InterfacePtrSet removes it when an error occurred on the connection.
	18 }

	19

	20 } // namespace memory_coordinator

OLD	NEW