Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 2094573002: [wasm] Cleaning up code (Closed)

Created:
4 years, 6 months ago by ritesht
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Cleaning up code Cleaning up the code to replace all instances of "i++" in for loops with the more efficient "++i". The latter foregoes an extra intermediate variable. BUG=v8:5044 Committed: https://crrev.com/3a5b4ae9f11ee7b220ace0263b5720a83e930d0f Cr-Commit-Position: refs/heads/master@{#37230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M src/compiler/wasm-compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wasm/asm-wasm-builder.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/wasm/ast-decoder.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/wasm/encoder.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/wasm/module-decoder.cc View 14 chunks +15 lines, -15 lines 0 comments Download
M src/wasm/switch-logic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/wasm/wasm-opcodes.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ritesht
[wasm] Changing the instances of "i++" with "++i" in the for loops
4 years, 6 months ago (2016-06-23 18:17:14 UTC) #3
bradnelson
lgtm, but you'll also need Mircea for stuff under src/compiler.
4 years, 6 months ago (2016-06-23 18:25:40 UTC) #4
ritesht
[wasm] Replacing all instances of "i++" with "++i" in the wasm code
4 years, 6 months ago (2016-06-23 20:08:07 UTC) #6
Mircea Trofin
On 2016/06/23 20:08:07, ritesht wrote: > [wasm] Replacing all instances of "i++" with "++i" in ...
4 years, 6 months ago (2016-06-23 22:07:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2094573002/1
4 years, 6 months ago (2016-06-23 22:24:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 22:26:13 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 22:29:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a5b4ae9f11ee7b220ace0263b5720a83e930d0f
Cr-Commit-Position: refs/heads/master@{#37230}

Powered by Google App Engine
This is Rietveld 408576698