MD - Fix coloring of buttons on DL shelf.

MD - Fix coloring of buttons on DL shelf.

This fixes themes as well as incognito.

BUG=621467
Committed: https://crrev.com/fdea3ac49bea89fb560dd555c5fc710b54fbc316
Cr-Commit-Position: refs/heads/master@{#401702}

[Evan Stade, 2016-06-23 00:19:09]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-06-23 15:28:00]

https://codereview.chromium.org/2094553002/diff/1/chrome/browser/ui/views/dow...
File chrome/browser/ui/views/download/download_shelf_view.cc (right):

https://codereview.chromium.org/2094553002/diff/1/chrome/browser/ui/views/dow...
chrome/browser/ui/views/download/download_shelf_view.cc:396:
static_cast<views::LabelButton*>(show_all_view_)
grumble, static_cast, grumble.
This cast is easy to miss and fragile. How about adding another member, say
show_all_view_md_ this is the LableButton?

[Evan Stade, 2016-06-23 17:05:49]

https://codereview.chromium.org/2094553002/diff/1/chrome/browser/ui/views/dow...
File chrome/browser/ui/views/download/download_shelf_view.cc (right):

https://codereview.chromium.org/2094553002/diff/1/chrome/browser/ui/views/dow...
chrome/browser/ui/views/download/download_shelf_view.cc:396:
static_cast<views::LabelButton*>(show_all_view_)
On 2016/06/23 15:28:00, sky wrote:
> grumble, static_cast, grumble.
> This cast is easy to miss and fragile. How about adding another member, say
> show_all_view_md_ this is the LableButton?

well hopefully we'll be able to rip out non-md code soon which would obviate the
need for this cast, but I've gone ahead and added the member.

[Evan Stade, 2016-06-23 17:05:58]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 17:06:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2094553002/20001

[commit-bot: I haz the power, 2016-06-23 17:20:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 17:20:33]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-06-23 19:11:23]

LGTM

[Evan Stade, 2016-06-23 20:18:05]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-06-23 20:18:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2094553002/40001

[commit-bot: I haz the power, 2016-06-23 20:23:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-23 20:26:47]

Description was changed from

==========
MD - Fix coloring of buttons on DL shelf.

This fixes themes as well as incognito.

BUG=621467
==========

to

==========
MD - Fix coloring of buttons on DL shelf.

This fixes themes as well as incognito.

BUG=621467

Committed: https://crrev.com/fdea3ac49bea89fb560dd555c5fc710b54fbc316
Cr-Commit-Position: refs/heads/master@{#401702}
==========

[commit-bot: I haz the power, 2016-06-23 20:26:48]

Patchset 3 (id:??) landed as
https://crrev.com/fdea3ac49bea89fb560dd555c5fc710b54fbc316
Cr-Commit-Position: refs/heads/master@{#401702}