Add support for mojo::TypeConverter to control how convenient conversion should be.

mojo/public/cpp/bindings/type_converter.h

Index: mojo/public/cpp/bindings/type_converter.h
diff --git a/mojo/public/cpp/bindings/type_converter.h b/mojo/public/cpp/bindings/type_converter.h
index 350fcf0be2bd38d59ce6305357e1503e45166b91..ec574b4859054983198492b119963d2dfcb935cd 100644
--- a/mojo/public/cpp/bindings/type_converter.h
+++ b/mojo/public/cpp/bindings/type_converter.h
@@ -44,25 +44,67 @@ namespace mojo {
 //
 // With the above TypeConverter defined, it is possible to write code like this:
 //
-//   void SomeFunction(const gfx::Point& pt);
-//
 //   void AcceptPoint(const geometry::Point& input) {
 //     // With an explicit cast using the .To<> method.
 //     gfx::Point pt = input.To<gfx::Point>();
 //
-//     // With an implicit copy conversion:
+//     mojo::AllocationScope scope;
+//     // With an explicit cast using the static From() method.
+//     geometry::Point output = geometry::Point::From(pt);
+//   }
+//
+// More "direct" conversions can be enabled by adding the following macro to the
+// TypeConverter specialization:
+//  MOJO_ALLOW_DIRECT_TYPE_CONVERSION();
+//
+// To be exact, this amcro enables:
+// - converting constructor:
+//   T(const U& u, mojo::Buffer* buf = mojo::Buffer::current());
+// - assignment operator:
+//   T& operator=(const U& u);
+// - conversion operator:
+//   operator U() const;
+//
+// If the macro is added to TypeConverter<geometry::Point, gfx::Point>, for
+// example, it is possible to write code like this:
+//
+//   void SomeFunction(const gfx::Point& pt);
+//
+//   void AcceptPoint(const geometry::Point& input) {
+//     // Using the conversion operator.
 //     SomeFunction(input);
 //
 //     mojo::AllocationScope scope;
-//     // With an implicit copy conversion:
-//     geometry::Point output = pt;
+//     // Using the converting constructor.
+//     geometry::Point output_1(pt);
+//
+//     geometry::Point output_2;
+//     // Using the assignment operator.
+//     output_2 = pt;
 //   }
 //
+// Although this macro is convenient, it makes conversions less obvious. Users
+// may do conversions excessively without paying attention to the cost. So
+// please use it wisely.
 template <typename T, typename U> class TypeConverter {
   // static T ConvertFrom(const U& input, Buffer* buf);
   // static U ConvertTo(const T& input);
+
+  // Maybe:
+  // MOJO_ALLOW_DIRECT_TYPE_CONVERSION();
 };
 
 }  // namespace mojo
 
+#define MOJO_ALLOW_DIRECT_TYPE_CONVERSION() \

[yzshen1, 2014/04/23 00:14:24]

I think it is more clear to put the macro definitions here, but please let me
know if you think they should be in mojo/public/cpp/system/macros.h

[darin (slow to review), 2014/04/23 18:01:01]

Yes, this is the right place for this. It doesn't need to go into the general
macros.h since it is not a general purpose macro.

+    typedef void AllowDirectTypeConversion
+
+// Fails compilation if MOJO_ALLOW_DIRECT_TYPE_CONVERSION() is not specified in
+// TypeConverter<T, U>.
+#define MOJO_INTERNAL_CHECK_ALLOW_DIRECT_TYPE_CONVERSION(T, U) \
+    do { \
+      typedef typename mojo::TypeConverter<T, U>::AllowDirectTypeConversion \
+          FailedIfNotAllowed; \
+    } while (false)
+
 #endif  // MOJO_PUBLIC_CPP_BINDINGS_TYPE_CONVERTER_H_