Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2094513003: views: Restore to old behaviour of Widget::ReparentNativeView(). (Closed)

Created:
4 years, 6 months ago by sadrul
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: Restore to old behaviour of Widget::ReparentNativeView(). Restore the previous behaviour of Widget::ReparentNativeView() of parenting the window to the root-window, instead of detaching it from the window tree. This is necessary since copy-requests on the window cannot be performed when the window is detached from the layer-tree. This breaks, among other things, capturing thumbnail of a page when it is backgrounded. BUG=621018, 616399 Committed: https://crrev.com/31cbd8a0d0760694e913ed8de1f33bc8a416e84b Cr-Commit-Position: refs/heads/master@{#401629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M ui/views/controls/native/native_view_host_aura_unittest.cc View 1 chunk +17 lines, -8 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +17 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sadrul
4 years, 6 months ago (2016-06-23 06:53:16 UTC) #2
sky
LGTM - I thought that code was there for a reason.
4 years, 6 months ago (2016-06-23 15:35:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2094513003/1
4 years, 6 months ago (2016-06-23 16:40:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 16:45:13 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 16:48:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31cbd8a0d0760694e913ed8de1f33bc8a416e84b
Cr-Commit-Position: refs/heads/master@{#401629}

Powered by Google App Engine
This is Rietveld 408576698