Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: services/media/factory_service/media_player_impl.cc

Issue 2094473002: Motown: Don't build out pipelines for streams that don't get rendered. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Remove NullTimelineControlSite placeholder - no longer needed. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/media/factory_service/media_sink_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/media/factory_service/media_player_impl.cc
diff --git a/services/media/factory_service/media_player_impl.cc b/services/media/factory_service/media_player_impl.cc
index ee33b06a47359f9d292026e2d6539b96872fbf73..c9b90bbec721251bfe8c68b5e461856b4be5a7e4 100644
--- a/services/media/factory_service/media_player_impl.cc
+++ b/services/media/factory_service/media_player_impl.cc
@@ -65,14 +65,18 @@ MediaPlayerImpl::MediaPlayerImpl(InterfaceHandle<SeekingReader> reader,
Stream& stream = *streams_.back();
switch (stream_type->medium) {
case MediaTypeMedium::AUDIO:
- stream.renderer_ = audio_renderer_.Pass();
- PrepareStream(&stream, streams_.size() - 1, stream_type,
- callback_joiner->NewCallback());
+ if (audio_renderer_) {
+ stream.renderer_ = audio_renderer_.Pass();
+ PrepareStream(&stream, streams_.size() - 1, stream_type,
+ callback_joiner->NewCallback());
+ }
break;
case MediaTypeMedium::VIDEO:
- stream.renderer_ = video_renderer_.Pass();
- PrepareStream(&stream, streams_.size() - 1, stream_type,
- callback_joiner->NewCallback());
+ if (video_renderer_) {
+ stream.renderer_ = video_renderer_.Pass();
+ PrepareStream(&stream, streams_.size() - 1, stream_type,
+ callback_joiner->NewCallback());
+ }
break;
// TODO(dalesat): Enable other stream types.
default:
« no previous file with comments | « no previous file | services/media/factory_service/media_sink_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698