Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2094473002: Motown: Don't build out pipelines for streams that don't get rendered. (Closed)

Created:
4 years, 6 months ago by dalesat
Modified:
4 years, 6 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Motown: Don't build out pipelines for streams that don't get rendered. Previously, Motown has built pipelines for any audio or video stream, even if the application hasn't provided a renderer for the stream. This was done to test video decoding before we had a video renderer. Now that we have a video renderer, this is no longer required. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/54b8b0366c0b3a85a93b10cf545462dc0f79dc0d

Patch Set 1 #

Patch Set 2 : Remove NullTimelineControlSite placeholder - no longer needed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -80 lines) Patch
M services/media/factory_service/media_player_impl.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M services/media/factory_service/media_sink_impl.h View 1 1 chunk +0 lines, -30 lines 0 comments Download
M services/media/factory_service/media_sink_impl.cc View 1 3 chunks +3 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dalesat
Please take a look. Thanks!
4 years, 6 months ago (2016-06-22 18:11:03 UTC) #3
kulakowski
On 2016/06/22 18:11:03, dalesat wrote: > Please take a look. Thanks! lgtm pending bots
4 years, 6 months ago (2016-06-22 18:12:47 UTC) #4
dalesat
4 years, 6 months ago (2016-06-22 18:52:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
54b8b0366c0b3a85a93b10cf545462dc0f79dc0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698