Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: test/cctest/test-parsing.cc

Issue 2094463002: Allow trailing commas in function parameter lists (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/parser-base.h ('k') | test/mjsunit/harmony/trailing-commas-length.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index ab1fc765991cf6206ce13ca35d03be3441940628..ca9cb2c20cee19c0c3a20b120c4c4e68d85893b0 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -1511,6 +1511,7 @@ enum ParserFlag {
kAllowHarmonyForIn,
kAllowHarmonyAsyncAwait,
kAllowHarmonyRestrictiveGenerators,
+ kAllowHarmonyTrailingCommas,
};
enum ParserSyncTestResult {
@@ -1535,6 +1536,8 @@ void SetParserFlags(i::ParserBase<Traits>* parser,
flags.Contains(kAllowHarmonyAsyncAwait));
parser->set_allow_harmony_restrictive_generators(
flags.Contains(kAllowHarmonyRestrictiveGenerators));
+ parser->set_allow_harmony_trailing_commas(
+ flags.Contains(kAllowHarmonyTrailingCommas));
}
@@ -7840,3 +7843,107 @@ TEST(NoDuplicateAsyncFunctionInBlock) {
RunParserSyncTest(top_level_context_data, error_data, kSuccess, NULL, 0,
always_flags, arraysize(always_flags));
}
+
+TEST(TrailingCommasInParameters) {
+ // clang-format off
+ const char* context_data[][2] = {
+ { "", "" },
+ { "'use strict';", "" },
+ { "function foo() {", "}" },
+ { "function foo() {'use strict';", "}" },
+ { NULL, NULL }
+ };
+
+ const char* data[] = {
+ " function a(b,) {}",
+ " function* a(b,) {}",
+ "(function a(b,) {});",
+ "(function* a(b,) {});",
+ "(function (b,) {});",
+ "(function* (b,) {});",
+ " function a(b,c,d,) {}",
+ " function* a(b,c,d,) {}",
+ "(function a(b,c,d,) {});",
+ "(function* a(b,c,d,) {});",
+ "(function (b,c,d,) {});",
+ "(function* (b,c,d,) {});",
+ "(b,) => {};",
+ "(b,c,d,) => {};",
+ "a(1,);",
+ "a(1,2,3,);",
+ "a(...[],);",
+ "a(1, 2, ...[],);",
+ "a(...[], 2, ...[],);",
+ NULL
+ };
+ // clang-format on
+
+ static const ParserFlag always_flags[] = {kAllowHarmonyTrailingCommas};
+ RunParserSyncTest(context_data, data, kSuccess, NULL, 0, always_flags,
+ arraysize(always_flags));
+}
+
+TEST(TrailingCommasInParametersErrors) {
+ // clang-format off
+ const char* context_data[][2] = {
+ { "", "" },
+ { "'use strict';", "" },
+ { "function foo() {", "}" },
+ { "function foo() {'use strict';", "}" },
+ { NULL, NULL }
+ };
+
+ const char* data[] = {
+ // too many trailing commas
+ " function a(b,,) {}",
+ " function* a(b,,) {}",
+ "(function a(b,,) {});",
+ "(function* a(b,,) {});",
+ "(function (b,,) {});",
+ "(function* (b,,) {});",
+ " function a(b,c,d,,) {}",
+ " function* a(b,c,d,,) {}",
+ "(function a(b,c,d,,) {});",
+ "(function* a(b,c,d,,) {});",
+ "(function (b,c,d,,) {});",
+ "(function* (b,c,d,,) {});",
+ "(b,,) => {};",
+ "(b,c,d,,) => {};",
+ "a(1,,);",
+ "a(1,2,3,,);",
+ // only a trailing comma and no parameters
+ " function a1(,) {}",
+ " function* a2(,) {}",
+ "(function a3(,) {});",
+ "(function* a4(,) {});",
+ "(function (,) {});",
+ "(function* (,) {});",
+ "(,) => {};",
+ "a1(,);",
+ // no trailing commas after rest parameter declaration
+ " function a(...b,) {}",
+ " function* a(...b,) {}",
+ "(function a(...b,) {});",
+ "(function* a(...b,) {});",
+ "(function (...b,) {});",
+ "(function* (...b,) {});",
+ " function a(b, c, ...d,) {}",
+ " function* a(b, c, ...d,) {}",
+ "(function a(b, c, ...d,) {});",
+ "(function* a(b, c, ...d,) {});",
+ "(function (b, c, ...d,) {});",
+ "(function* (b, c, ...d,) {});",
+ "(...b,) => {};",
+ "(b, c, ...d,) => {};",
+ // parenthesized trailing comma without arrow is still an error
+ "(,);",
+ "(a,);",
+ "(a,b,c,);",
+ NULL
+ };
+ // clang-format on
+
+ static const ParserFlag always_flags[] = {kAllowHarmonyTrailingCommas};
+ RunParserSyncTest(context_data, data, kError, NULL, 0, always_flags,
+ arraysize(always_flags));
+}
« no previous file with comments | « src/parsing/parser-base.h ('k') | test/mjsunit/harmony/trailing-commas-length.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698