Use some FXSYS methods instead of duplicating

Use some FXSYS methods instead of duplicating

This CL uses the FXSYS_isDecimalDigit in place of a few custom IsDigit methods.
It also creates an iswspace and some fractional math helper methods to share
some code.

Committed: https://pdfium.googlesource.com/pdfium/+/ce56557ef58facf2519f541d5cad33ea121b4c21

[dsinclair, 2016-06-23 20:33:17]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-06-23 20:33:18]

PTAL.

https://codereview.chromium.org/2094453004/diff/1/xfa/fxfa/parser/xfa_localev...
File xfa/fxfa/parser/xfa_localevalue.cpp (right):

https://codereview.chromium.org/2094453004/diff/1/xfa/fxfa/parser/xfa_localev...
xfa/fxfa/parser/xfa_localevalue.cpp:19: static const FX_DOUBLE fraction_scales[]
= {0.1,
This one has more values (16 vs 11) so I've left it for now.

[Lei Zhang, 2016-06-23 20:42:09]

lgtm

https://codereview.chromium.org/2094453004/diff/1/xfa/fgas/localization/fgas_...
File xfa/fgas/localization/fgas_locale.cpp (right):

https://codereview.chromium.org/2094453004/diff/1/xfa/fgas/localization/fgas_...
xfa/fgas/localization/fgas_locale.cpp:144: else
no need, ditto for line 170

[dsinclair, 2016-06-23 20:45:48]

https://codereview.chromium.org/2094453004/diff/1/xfa/fgas/localization/fgas_...
File xfa/fgas/localization/fgas_locale.cpp (right):

https://codereview.chromium.org/2094453004/diff/1/xfa/fgas/localization/fgas_...
xfa/fgas/localization/fgas_locale.cpp:144: else
On 2016/06/23 20:42:08, Lei Zhang (Slow) wrote:
> no need, ditto for line 170

Done.

[dsinclair, 2016-06-23 20:46:03]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-06-23 20:46:04]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2094453004/#ps20001
(title: "Review cleanup")

[commit-bot: I haz the power, 2016-06-23 20:46:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2094453004/20001

[commit-bot: I haz the power, 2016-06-23 21:00:37]

Description was changed from

==========
Use some FXSYS methods instead of duplicating

This CL uses the FXSYS_isDecimalDigit in place of a few custom IsDigit methods.
It also creates an iswspace and some fractional math helper methods to share
some code.
==========

to

==========
Use some FXSYS methods instead of duplicating

This CL uses the FXSYS_isDecimalDigit in place of a few custom IsDigit methods.
It also creates an iswspace and some fractional math helper methods to share
some code.

Committed:
https://pdfium.googlesource.com/pdfium/+/ce56557ef58facf2519f541d5cad33ea121b...
==========

[commit-bot: I haz the power, 2016-06-23 21:00:38]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/ce56557ef58facf2519f541d5cad33ea121b...