Delete Promises Layout Tests.

Delete Promises Layout Tests.

Promises are now implemented tested in V8.
I delete Promises tests except for tests testing ScriptPromise or
ScriptPromiseResolver.

BUG=352597
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169916

[jochen (gone - plz use gerrit), 2014-03-25 06:29:08]

lgtm

[yhirano, 2014-03-25 06:30:27]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-03-25 06:30:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/209443009/1

[commit-bot: I haz the power, 2014-03-25 07:39:56]

Change committed as 169916

[adamk, 2014-05-27 23:29:36]

I just noticed this patch as I was trying to change some code in
ScriptPromiseResolverWithContext.

Do we have any tests of Promise behavior in workers? This patch removed all the
ones I could find...

[jochen (gone - plz use gerrit), 2014-05-28 12:50:50]

On 2014/05/27 23:29:36, adamk wrote:
> I just noticed this patch as I was trying to change some code in
> ScriptPromiseResolverWithContext.
> 
> Do we have any tests of Promise behavior in workers? This patch removed all
the
> ones I could find...

we moved those tests to v8, as they're purely javascript

maybe we should just add them back as they're now also exercising the
interaction with the dom microtask queue?

[yhirano, 2014-05-29 02:22:24]

On 2014/05/28 12:50:50, jochen wrote:
> On 2014/05/27 23:29:36, adamk wrote:
> > I just noticed this patch as I was trying to change some code in
> > ScriptPromiseResolverWithContext.
> > 
> > Do we have any tests of Promise behavior in workers? This patch removed all
> the
> > ones I could find...
> 
> we moved those tests to v8, as they're purely javascript
> 
> maybe we should just add them back as they're now also exercising the
> interaction with the dom microtask queue?

Are you talking about Promise or ScriptPromiseResolverWithContext?
Adding a few simple tests that use Promise to check if Microtask is working
seems reasonable.
There are some DOM objects that use ScriptPromiseResolverWtihContext in a worker
thread, for example fast/canvas/canvas-createImageBitmap-blob-in-workers .

[adamk, 2014-05-30 22:30:46]

On Wed, May 28, 2014 at 7:22 PM, <yhirano@chromium.org> wrote:

> On 2014/05/28 12:50:50, jochen wrote:
>
>> On 2014/05/27 23:29:36, adamk wrote:
>> > I just noticed this patch as I was trying to change some code in
>> > ScriptPromiseResolverWithContext.
>> >
>> > Do we have any tests of Promise behavior in workers? This patch removed
>> all
>> the
>> > ones I could find...
>>
>
>  we moved those tests to v8, as they're purely javascript
>>
>
>  maybe we should just add them back as they're now also exercising the
>> interaction with the dom microtask queue?
>>
>
> Are you talking about Promise or ScriptPromiseResolverWithContext?
> Adding a few simple tests that use Promise to check if Microtask is working
> seems reasonable.
> There are some DOM objects that use ScriptPromiseResolverWtihContext in a
> worker
> thread, for example fast/canvas/canvas-createImageBitmap-blob-in-workers .
>

To close this thread, I found the canvas test you pointed at to be
sufficient for exercising ScriptPromiseResolverWithContext in a worker. I
think it's probably best to not have promise-specific, but rather
features-that-use-promise-specific LayoutTests, like this one. So the
decision to remove the tests originally seems fine to me.

One more thing: it looks like a few JS files got left behind when these
tests were removed, so I might send out another Cl to delete those (in
fast/js/resources/*promise*)

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.