Source/core/css/parser/CSSPropertyParser.cpp - Issue 209443007: Remove shape-inside support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 209443007: Remove shape-inside support (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix more (all?) tests Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp

index 4c25c666dbde77e24f4481c8411dd47d925d09b5..a03eeae62f4a675c843a92556bb0ddf250d53089 100644

--- a/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/Source/core/css/parser/CSSPropertyParser.cpp

@@ -1483,7 +1483,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID propId, bool important)

return true;

}

break;

- case CSSPropertyShapeInside:

case CSSPropertyShapeOutside:

parsedValue = parseShapeProperty(propId);

break;

@@ -4203,8 +4202,7 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::parseShapeProperty(CSSProper

RefPtrWillBeRawPtr<CSSPrimitiveValue> boxValue;

RefPtrWillBeRawPtr<CSSPrimitiveValue> shapeValue;

- if (valueId == CSSValueNone

- || (valueId == CSSValueOutsideShape && propId == CSSPropertyShapeInside)) {

+ if (valueId == CSSValueNone) {

RefPtrWillBeRawPtr<CSSPrimitiveValue> keywordValue = parseValidPrimitive(valueId, value);

m_valueList->next();

return keywordValue.release();