Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1586)

Unified Diff: Source/core/rendering/RenderBlock.h

Issue 209443007: Remove shape-inside support (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix Zoltan's comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderBlock.h
diff --git a/Source/core/rendering/RenderBlock.h b/Source/core/rendering/RenderBlock.h
index baf307e1b73f48cb57c96bf7421cd3baeb90c393..2873269d534e81352dc5458fe7e7f0c5da0d76b1 100644
--- a/Source/core/rendering/RenderBlock.h
+++ b/Source/core/rendering/RenderBlock.h
@@ -29,7 +29,6 @@
#include "core/rendering/RenderBox.h"
#include "core/rendering/RenderLineBoxList.h"
#include "core/rendering/RootInlineBox.h"
-#include "core/rendering/shapes/ShapeInsideInfo.h"
#include "core/rendering/style/ShapeValue.h"
#include "platform/text/TextBreakIterator.h"
#include "platform/text/TextRun.h"
@@ -144,7 +143,6 @@ public:
bool hasMarginBeforeQuirk(const RenderBox* child) const;
bool hasMarginAfterQuirk(const RenderBox* child) const;
- void markShapeInsideDescendantsForLayout();
void markPositionedObjectsForLayout();
// FIXME: Do we really need this to be virtual? It's just so we can call this on
// RenderBoxes without needed to check whether they're RenderBlocks first.
@@ -263,24 +261,6 @@ public:
void showLineTreeAndMark(const InlineBox* = 0, const char* = 0, const InlineBox* = 0, const char* = 0, const RenderObject* = 0) const;
#endif
- ShapeInsideInfo& ensureShapeInsideInfo()
- {
- if (!m_rareData || !m_rareData->m_shapeInsideInfo)
- setShapeInsideInfo(ShapeInsideInfo::createInfo(*this));
- return *m_rareData->m_shapeInsideInfo;
- }
- ShapeInsideInfo* shapeInsideInfo() const
- {
- return m_rareData && m_rareData->m_shapeInsideInfo && ShapeInsideInfo::isEnabledFor(*this) ? m_rareData->m_shapeInsideInfo.get() : 0;
- }
- void setShapeInsideInfo(PassOwnPtr<ShapeInsideInfo> value)
- {
- if (!m_rareData)
- m_rareData = adoptPtr(new RenderBlockRareData());
- m_rareData->m_shapeInsideInfo = value;
- }
- ShapeInsideInfo* layoutShapeInsideInfo() const;
- bool allowsShapeInsideInfoSharing(const RenderBlock* other) const;
LayoutSize logicalOffsetFromShapeAncestorContainer(const RenderBlock* container) const;
virtual void imageChanged(WrappedImagePtr, const IntRect* = 0) OVERRIDE;
@@ -361,7 +341,6 @@ protected:
virtual void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOffset) const OVERRIDE;
- bool updateRegionsAndShapesLogicalSize(RenderFlowThread*);
void computeRegionRangeForBlock(RenderFlowThread*);
void updateBlockChildDirtyBitsBeforeLayout(bool relayoutChildren, RenderBox*);
@@ -369,10 +348,7 @@ protected:
virtual bool isInlineBlockOrInlineTable() const OVERRIDE FINAL { return isInline() && isReplaced(); }
private:
- void computeShapeSize();
void updateRegionsAndShapesAfterChildLayout(RenderFlowThread*, bool);
- void updateShapeInsideInfoAfterStyleChange(const ShapeValue*, const ShapeValue* oldShape);
- void relayoutShapeDescendantIfMoved(RenderBlock* child, LayoutSize offset);
virtual RenderObjectChildList* virtualChildren() OVERRIDE FINAL { return children(); }
virtual const RenderObjectChildList* virtualChildren() const OVERRIDE FINAL { return children(); }
@@ -548,7 +524,6 @@ public:
LayoutUnit m_paginationStrut;
LayoutUnit m_pageLogicalOffset;
- OwnPtr<ShapeInsideInfo> m_shapeInsideInfo;
int m_lineBreakToAvoidWidow : 31;
unsigned m_didBreakAtLineToAvoidWidow : 1;
};
@@ -579,20 +554,6 @@ protected:
friend class RenderBlockFlow;
};
-
-inline bool RenderBlock::allowsShapeInsideInfoSharing(const RenderBlock* other) const
-{
- if (!other)
- return false;
- for (const RenderBlock* current = this; current && current != other && !current->isRenderFlowThread(); current = current->containingBlock()) {
- if (current->isInline() || current->isFloating())
- return false;
- if (current->parent() != current->containingBlock())
- return false;
- }
- return true;
-}
-
DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderBlock, isRenderBlock());
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698