Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: sdk/lib/io/websocket_impl.dart

Issue 209443005: Add optimized _OneByteString.toLowerCase. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Optimize toLowerCase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/io/common.dart ('K') | « sdk/lib/io/http_parser.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/websocket_impl.dart
diff --git a/sdk/lib/io/websocket_impl.dart b/sdk/lib/io/websocket_impl.dart
index ee56378d788a279caf39372d7084f05931c712b9..76ee77d7b97360c266a134170a851d1b3f733655 100644
--- a/sdk/lib/io/websocket_impl.dart
+++ b/sdk/lib/io/websocket_impl.dart
@@ -464,11 +464,11 @@ class _WebSocketTransformerImpl implements WebSocketTransformer {
}
bool isUpgrade = false;
request.headers[HttpHeaders.CONNECTION].forEach((String value) {
- if (value.toLowerCase() == "upgrade") isUpgrade = true;
+ if (_ASCII.toLowerCase(value) == "upgrade") isUpgrade = true;
});
if (!isUpgrade) return false;
String upgrade = request.headers.value(HttpHeaders.UPGRADE);
- if (upgrade == null || upgrade.toLowerCase() != "websocket") {
+ if (upgrade == null || _ASCII.toLowerCase(upgrade) != "websocket") {
return false;
}
String version = request.headers.value("Sec-WebSocket-Version");
@@ -834,8 +834,8 @@ class _WebSocketImpl extends Stream implements WebSocket {
if (response.statusCode != HttpStatus.SWITCHING_PROTOCOLS ||
response.headers[HttpHeaders.CONNECTION] == null ||
!response.headers[HttpHeaders.CONNECTION].any(
- (value) => value.toLowerCase() == "upgrade") ||
- response.headers.value(HttpHeaders.UPGRADE).toLowerCase() !=
+ (value) => _ASCII.toLowerCase(value) == "upgrade") ||
+ _ASCII.toLowerCase(response.headers.value(HttpHeaders.UPGRADE)) !=
"websocket") {
error("Connection to '$uri' was not upgraded to websocket");
}
« sdk/lib/io/common.dart ('K') | « sdk/lib/io/http_parser.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698