Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2094413003: Add some perftests for wait sets. (Closed)

Created:
4 years, 5 months ago by viettrungluu
Modified:
4 years, 5 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add some perftests for wait sets. The main important of these tests is to verify that they behave reasonably as wait set size varies. (The overhead per wait should be O(1) or O(log n) in the wait set size n. Currently it's probably O(log n), since we use an std::map for lookups, but obviously we could use a hash table instead.) R=azani@chromium.org BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/c6f7609574beef8afdeee72fd777aed9bdb67d7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -1 line) Patch
M mojo/public/c/system/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/c/system/tests/message_pipe_perftest.cc View 2 chunks +2 lines, -1 line 0 comments Download
A mojo/public/c/system/tests/wait_set_perftest.cc View 1 chunk +179 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 5 months ago (2016-06-27 22:52:57 UTC) #1
azani
lgtm
4 years, 5 months ago (2016-06-27 22:55:05 UTC) #2
viettrungluu
4 years, 5 months ago (2016-06-27 22:59:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c6f7609574beef8afdeee72fd777aed9bdb67d7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698