Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: net/proxy/proxy_resolver_mac.h

Issue 2094373002: Synchronize events of CFNetworkExecuteProxyAutoConfigurationURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Eric's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/proxy/proxy_resolver_mac.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_PROXY_PROXY_RESOLVER_MAC_H_ 5 #ifndef NET_PROXY_PROXY_RESOLVER_MAC_H_
6 #define NET_PROXY_PROXY_RESOLVER_MAC_H_ 6 #define NET_PROXY_PROXY_RESOLVER_MAC_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "net/base/net_export.h" 10 #include "net/base/net_export.h"
11 #include "net/proxy/proxy_resolver_factory.h" 11 #include "net/proxy/proxy_resolver_factory.h"
12 #include "url/gurl.h" 12 #include "url/gurl.h"
13 13
14 namespace net { 14 namespace net {
15 15
16 // Implementation of ProxyResolverFactory that uses the Mac CFProxySupport to 16 // Implementation of ProxyResolverFactory that uses the Mac CFProxySupport to
17 // implement proxies. 17 // implement proxies.
18 // TODO(kapishnikov): make ProxyResolverMac async as per
19 // https://bugs.chromium.org/p/chromium/issues/detail?id=166387#c95
18 class NET_EXPORT ProxyResolverFactoryMac : public ProxyResolverFactory { 20 class NET_EXPORT ProxyResolverFactoryMac : public ProxyResolverFactory {
19 public: 21 public:
20 ProxyResolverFactoryMac(); 22 ProxyResolverFactoryMac();
21 23
22 int CreateProxyResolver( 24 int CreateProxyResolver(
23 const scoped_refptr<ProxyResolverScriptData>& pac_script, 25 const scoped_refptr<ProxyResolverScriptData>& pac_script,
24 std::unique_ptr<ProxyResolver>* resolver, 26 std::unique_ptr<ProxyResolver>* resolver,
25 const CompletionCallback& callback, 27 const CompletionCallback& callback,
26 std::unique_ptr<Request>* request) override; 28 std::unique_ptr<Request>* request) override;
27 29
28 private: 30 private:
29 DISALLOW_COPY_AND_ASSIGN(ProxyResolverFactoryMac); 31 DISALLOW_COPY_AND_ASSIGN(ProxyResolverFactoryMac);
30 }; 32 };
31 33
32 } // namespace net 34 } // namespace net
33 35
34 #endif // NET_PROXY_PROXY_RESOLVER_MAC_H_ 36 #endif // NET_PROXY_PROXY_RESOLVER_MAC_H_
OLDNEW
« no previous file with comments | « no previous file | net/proxy/proxy_resolver_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698