Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2094353002: [Interpreter] Remove failure expectation for observer-expectations blink test. (Closed)

Created:
4 years, 5 months ago by mythria
Modified:
4 years, 5 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Remove failure expectation for observer-expectations blink test. Removes failure expectation for observer-expectations layout test. BUG=v8:4280, v8:5096 LOG=N Committed: https://crrev.com/08cc2d4fd958e6e56942b5d54920a6a82454800b Cr-Commit-Position: refs/heads/master@{#37298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/blink_tests/TestExpectationsIgnition View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094353002/1
4 years, 5 months ago (2016-06-27 14:53:41 UTC) #2
mythria
PTAL. Is there a fyi try bot? I could not find it in the list ...
4 years, 5 months ago (2016-06-27 14:57:19 UTC) #5
rmcilroy
> Is there a fyi try bot? I could not find it in the list ...
4 years, 5 months ago (2016-06-27 15:04:56 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 15:18:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094353002/1
4 years, 5 months ago (2016-06-27 16:05:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 16:07:45 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 16:10:36 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08cc2d4fd958e6e56942b5d54920a6a82454800b
Cr-Commit-Position: refs/heads/master@{#37298}

Powered by Google App Engine
This is Rietveld 408576698