Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2094343005: Fix MD button hover shadow effect on odd-sized buttons. (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 5 months ago
Reviewers:
sky, bruthig
CC:
chromium-reviews, asanka, tfarina, dcheng, bruthig+ink_drop_chromium.org, noyau+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MD button hover shadow effect on odd-sized buttons. gfx::Point -> gfx::PointF to fix rounding errors. BUG=623776 Committed: https://crrev.com/9e35190510f4f028f24beac01204f6ef9d6d0643 Cr-Commit-Position: refs/heads/master@{#402567}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view_md.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/animation/ink_drop_highlight.h View 1 chunk +2 lines, -2 lines 1 comment Download
M ui/views/animation/ink_drop_highlight.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/animation/ink_drop_highlight_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/ink_drop_host_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/ink_drop_host_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/controls/button/md_text_button.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Evan Stade
4 years, 5 months ago (2016-06-28 00:02:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094343005/1
4 years, 5 months ago (2016-06-28 00:04:12 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 01:41:59 UTC) #7
sky
LGTM https://codereview.chromium.org/2094343005/diff/1/ui/views/animation/ink_drop_highlight.h File ui/views/animation/ink_drop_highlight.h (right): https://codereview.chromium.org/2094343005/diff/1/ui/views/animation/ink_drop_highlight.h#newcode115 ui/views/animation/ink_drop_highlight.h:115: gfx::PointF center_point_; I'm surprised we stored a float ...
4 years, 5 months ago (2016-06-28 02:46:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094343005/1
4 years, 5 months ago (2016-06-28 21:51:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 22:14:27 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9e35190510f4f028f24beac01204f6ef9d6d0643 Cr-Commit-Position: refs/heads/master@{#402567}
4 years, 5 months ago (2016-06-28 22:17:26 UTC) #14
bruthig
4 years, 5 months ago (2016-06-30 13:26:21 UTC) #15
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698