Issue 2094343004: SoM: Fixed unwanted autorefreshing bug.

https://codereview.chromium.org/2094343004/diff/1/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html File go/src/infra/appengine/sheriff-o-matic/elements/som-app.html (right): https://codereview.chromium.org/2094343004/diff/1/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html#newcode340 go/src/infra/appengine/sheriff-o-matic/elements/som-app.html:340: return this._computeSelectedPage(path) == "alertsList"; why don't you just depend ...

4 years, 5 months ago (2016-06-27 23:40:14 UTC) #3

Tiff

On 2016/06/27 at 23:40:14, martiniss wrote: > https://codereview.chromium.org/2094343004/diff/1/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html > File go/src/infra/appengine/sheriff-o-matic/elements/som-app.html (right): > > https://codereview.chromium.org/2094343004/diff/1/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html#newcode340 ...

4 years, 5 months ago (2016-06-27 23:45:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094343004/20001

4 years, 5 months ago (2016-06-27 23:47:49 UTC) #7

commit-bot: I haz the power

4 years, 5 months ago (2016-06-28 00:05:08 UTC) #9

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/b7ec65be9273464c4035b6a2243f2...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 2094343004: SoM: Fixed unwanted autorefreshing bug. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Changed to use variable directly. #

Messages