CompressedCopyTextureCHROMIUM: validate texture targets before looking up levels

CompressedCopyTextureCHROMIUM: validate texture targets before looking up levels

We can't copy cube map or 3D textures using CompressedCopyTextureCHROMIUM, make
sure we check the targets before trying to look up level images etc. otherwise
we'll use the wrong target (texture target instead of image target).

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/bd2f4ca2bf375b407cfed78cc1ea2b140bcad0a2
Cr-Commit-Position: refs/heads/master@{#402636}

[piman, 2016-06-27 22:07:09]

Description was changed from

==========
CompressedCopyTextureCHROMIUM: validate texture targets before looking up levels

We can't copy cube map or 3D textures using CompressedCopyTextureCHROMIUM, make
sure we check the targets before trying to look up level images etc. otherwise
we'll use the wrong target (texture target instead of image target).

BUG=None
==========

to

==========
CompressedCopyTextureCHROMIUM: validate texture targets before looking up levels

We can't copy cube map or 3D textures using CompressedCopyTextureCHROMIUM, make
sure we check the targets before trying to look up level images etc. otherwise
we'll use the wrong target (texture target instead of image target).

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-06-27 22:07:25]

piman@chromium.org changed reviewers:
+ zmo@chromium.org

[Zhenyao Mo, 2016-06-28 17:43:01]

On 2016/06/27 22:07:26, piman wrote:

lgtm

[piman, 2016-06-28 18:13:10]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-06-28 18:14:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 19:48:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 19:48:54]

Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[piman, 2016-06-28 21:13:55]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-06-28 21:15:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 01:48:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 01:50:14]

Description was changed from

==========
CompressedCopyTextureCHROMIUM: validate texture targets before looking up levels

We can't copy cube map or 3D textures using CompressedCopyTextureCHROMIUM, make
sure we check the targets before trying to look up level images etc. otherwise
we'll use the wrong target (texture target instead of image target).

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
CompressedCopyTextureCHROMIUM: validate texture targets before looking up levels

We can't copy cube map or 3D textures using CompressedCopyTextureCHROMIUM, make
sure we check the targets before trying to look up level images etc. otherwise
we'll use the wrong target (texture target instead of image target).

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/bd2f4ca2bf375b407cfed78cc1ea2b140bcad0a2
Cr-Commit-Position: refs/heads/master@{#402636}
==========

[commit-bot: I haz the power, 2016-06-29 01:50:16]

Patchset 1 (id:??) landed as
https://crrev.com/bd2f4ca2bf375b407cfed78cc1ea2b140bcad0a2
Cr-Commit-Position: refs/heads/master@{#402636}