Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc

Issue 2094333002: Implementation for chrome.certificateProvider.requestPin/stopPinRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implemented review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc
diff --git a/chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc b/chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc
index 71ae76ffa18a1a148d3c67830a47b5aa919dedaa..bfad09a8afeb154210d54135c79431372cd857dc 100644
--- a/chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc
+++ b/chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc
@@ -485,4 +485,15 @@ TEST_F(CertificateProviderServiceTest, UnloadExtensionDuringSign) {
EXPECT_EQ(net::ERR_FAILED, error);
}
+TEST_F(CertificateProviderServiceTest, CloseDialogNoExtension) {
+ bool closed = service_->CloseDialog(std::string("extension_id"));
+ ASSERT_FALSE(closed);
emaxx 2016/09/06 15:02:11 nit: It's usually preferable to choose the EXPECT_
+}
+
+TEST_F(CertificateProviderServiceTest, LastDialogClosed) {
+ std::string extension_id("extension_id");
+ service_->OnPinDialogInput(extension_id, true);
+ ASSERT_TRUE(service_->LastPinDialogClosed(extension_id));
+}
+
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698