Implementation for chrome.certificateProvider.requestPin/stopPinRequest

chrome/browser/chromeos/ui/request_pin_view.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_UI_REQUEST_PIN_VIEW_H_
+#define CHROME_BROWSER_CHROMEOS_UI_REQUEST_PIN_VIEW_H_
+
+#include <memory>
+#include <string>
+
+#include "base/callback.h"
+#include "base/compiler_specific.h"
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "base/strings/string16.h"
+#include "ui/views/controls/textfield/textfield_controller.h"
+#include "ui/views/view.h"
+#include "ui/views/window/dialog_delegate.h"
+
+namespace views {
+class Label;
+}
+
+namespace chromeos {
+
+class PassphraseTextfield;
+
+enum RequestPinCodeType { PIN, PUK, UNCHANGED };
+
+enum RequestPinErrorType {
+  NONE,
+  INVALID_PIN,
+  INVALID_PUK,
+  MAX_ATTEMPTS_EXCEEDED,
+  UNKNOWN_ERROR
+};
+
+class CloseViewDelegate {
+ public:
+  // Notification when user closes the PIN dialog.
+  virtual void OnPinDialogClosed() = 0;
+};

[stevenjb, 2016/09/08 16:29:31]

This should be either defined within RequestPinView, e.g.
RequestPinView::Delegate, or in a separate header as RequestPinViewDelegate.
chromeos::CloseViewDelegate is much too generic of a name.

[igorcov, 2016/09/09 15:53:43]

Good point. Fixed.

+
+// A dialog box for requesting PIN code. Instances of this class are managed by
+// PinDialogManager.
+class RequestPinView : public views::DialogDelegateView,
+                       public views::TextfieldController {
+ public:
+  // Used to send the PIN/PUK entered by the user in the textfield to the
+  // extension that asked for the code.
+  using RequestPinCallback = base::Callback<void(const base::string16&)>;
+
+  // Creates the view to be embeded in the dialog that requests the PIN/PUK.
+  // |extension_name| - the name of the extension making the request. Displayed
+  //     in the title and in the header of the view.
+  // |code_type| - the type of code requested, PIN or PUK. UNCHANGED is not
+  //     accepted here.
+  // |attempts_left| - the number of attempts user has to try the code. When
+  //     zero the textfield is disabled and user cannot provide any input. When
+  //     -1 the user is allowed to provide the input and no information about
+  //     the attepts left is displayed in the view.
+  // |callback| - used to send the value of the PIN/PUK the user entered.
+  // |delegate| - used to notify that dialog was closed.
+  RequestPinView(const std::string& extension_name,
+                 RequestPinCodeType code_type,
+                 const int attempts_left,
+                 const RequestPinCallback& callback,
+                 CloseViewDelegate* delegate);
+  ~RequestPinView() override;
+
+  // views::TextfieldController
+  void ContentsChanged(views::Textfield* sender,
+                       const base::string16& new_contents) override;
+
+  // views::DialogDelegateView
+  bool Cancel() override;
+  bool Accept() override;
+  base::string16 GetWindowTitle() const override;
+  ui::ModalType GetModalType() const override;
+  views::View* GetInitiallyFocusedView() override;
+  bool IsDialogButtonEnabled(ui::DialogButton button) const override;
+
+  // Returns whether the view is locked while waiting the extension to process
+  // the user input data.
+  bool IsLocked();
+
+  // Set the new callback to be used when user will provide the input. The old
+  // callback should be null at this point.
+  void SetCallback(const RequestPinCallback& callback);
+
+  // |code_type| - specifies whether the user is asked to enter PIN or PUK. If
+  //     UNCHANGED value is provided, the dialog displays the same value that
+  //     was last set.
+  // |error_type| - the error template to be displayed in red in the dialog. If
+  //     NONE, no error is displayed.
+  // |attempts_left| - included in the view as the number of attepts user can
+  //     have to enter correct code.
+  // |accept_input| - specifies whether the textfield is enabled. If disabled
+  //     the user is unable to provide input.
+  void SetDialogParameters(RequestPinCodeType code_type,
+                           RequestPinErrorType error_type,
+                           const int attempts_left,
+                           const bool accept_input);
+
+  // Set the name of extension that is using this view. The name is included in
+  // the header text displayed by the view.
+  void SetExtensionName(const std::string& extension_name);
+
+  views::Textfield* textfield_for_testing() { return textfield_; }
+  views::Label* error_label_for_testing() { return error_label_; }
+
+ private:
+  // This initializes the view, with all the UI components.
+  void Init();
+  void SetAcceptInput(bool accept_input);
+  void SetErrorMessage(RequestPinErrorType error_type, int attempts_left);
+  // Updates the header text |header_label_| based on values from
+  // |window_title_| and |code_type_|.
+  void UpdateHeaderText();
+
+  // Used to send the input when the view is not locked. If user closes the
+  // view, the provided input is empty.
+  RequestPinCallback callback_;
+
+  // Owned by the caller.
+  CloseViewDelegate* delegate_;

[stevenjb, 2016/09/08 16:29:31]

nit: blank line separating commented member from other members.

[igorcov, 2016/09/09 15:53:43]

Done.

+  base::string16 window_title_;
+  views::Label* header_label_ = nullptr;
+  base::string16 code_type_;
+  views::Textfield* textfield_ = nullptr;
+  views::Label* error_label_ = nullptr;
+
+  base::WeakPtrFactory<RequestPinView> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(RequestPinView);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_UI_REQUEST_PIN_VIEW_H_