Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Side by Side Diff: chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

Issue 2094333002: Implementation for chrome.certificateProvider.requestPin/stopPinRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implemented review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <openssl/evp.h> 5 #include <openssl/evp.h>
6 #include <openssl/rsa.h> 6 #include <openssl/rsa.h>
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <stdlib.h> 9 #include <stdlib.h>
10 10
11 #include <memory> 11 #include <memory>
12 #include <string> 12 #include <string>
13 #include <vector> 13 #include <vector>
14 14
15 #include "base/bind.h" 15 #include "base/bind.h"
16 #include "base/callback.h" 16 #include "base/callback.h"
17 #include "base/files/file_path.h" 17 #include "base/files/file_path.h"
18 #include "base/files/file_util.h" 18 #include "base/files/file_util.h"
19 #include "base/run_loop.h" 19 #include "base/run_loop.h"
20 #include "base/strings/string_number_conversions.h" 20 #include "base/strings/string_number_conversions.h"
21 #include "base/strings/utf_string_conversions.h" 21 #include "base/strings/utf_string_conversions.h"
22 #include "base/values.h" 22 #include "base/values.h"
23 #include "chrome/browser/chromeos/certificate_provider/certificate_provider_serv ice.h"
24 #include "chrome/browser/chromeos/certificate_provider/certificate_provider_serv ice_factory.h"
25 #include "chrome/browser/extensions/api/certificate_provider/certificate_provide r_api.h"
23 #include "chrome/browser/extensions/extension_apitest.h" 26 #include "chrome/browser/extensions/extension_apitest.h"
24 #include "chrome/browser/ui/tabs/tab_strip_model.h" 27 #include "chrome/browser/ui/tabs/tab_strip_model.h"
25 #include "chrome/test/base/ui_test_utils.h" 28 #include "chrome/test/base/ui_test_utils.h"
26 #include "components/policy/core/browser/browser_policy_connector.h" 29 #include "components/policy/core/browser/browser_policy_connector.h"
27 #include "components/policy/core/common/mock_configuration_policy_provider.h" 30 #include "components/policy/core/common/mock_configuration_policy_provider.h"
28 #include "components/policy/core/common/policy_map.h" 31 #include "components/policy/core/common/policy_map.h"
29 #include "components/policy/core/common/policy_types.h" 32 #include "components/policy/core/common/policy_types.h"
30 #include "content/public/browser/render_frame_host.h" 33 #include "content/public/browser/render_frame_host.h"
31 #include "content/public/browser/web_contents.h" 34 #include "content/public/browser/web_contents.h"
32 #include "content/public/test/test_navigation_observer.h" 35 #include "content/public/test/test_navigation_observer.h"
33 #include "content/public/test/test_utils.h" 36 #include "content/public/test/test_utils.h"
34 #include "crypto/rsa_private_key.h" 37 #include "crypto/rsa_private_key.h"
35 #include "crypto/scoped_openssl_types.h" 38 #include "crypto/scoped_openssl_types.h"
36 #include "extensions/common/extension.h" 39 #include "extensions/common/extension.h"
37 #include "extensions/test/result_catcher.h" 40 #include "extensions/test/result_catcher.h"
38 #include "net/test/spawned_test_server/spawned_test_server.h" 41 #include "net/test/spawned_test_server/spawned_test_server.h"
39 #include "policy/policy_constants.h" 42 #include "policy/policy_constants.h"
40 #include "testing/gmock/include/gmock/gmock.h" 43 #include "testing/gmock/include/gmock/gmock.h"
44 #include "ui/views/controls/label.h"
45 #include "ui/views/controls/textfield/textfield.h"
46 #include "ui/views/widget/widget.h"
41 47
42 using testing::Return; 48 using testing::Return;
43 using testing::_; 49 using testing::_;
44 50
45 namespace { 51 namespace {
46 52
47 void IgnoreResult(const base::Closure& callback, const base::Value* value) { 53 void IgnoreResult(const base::Closure& callback, const base::Value* value) {
48 callback.Run(); 54 callback.Run();
49 } 55 }
50 56
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 std::string JsUint8Array(const std::vector<uint8_t>& bytes) { 121 std::string JsUint8Array(const std::vector<uint8_t>& bytes) {
116 std::string res = "new Uint8Array(["; 122 std::string res = "new Uint8Array([";
117 for (const uint8_t byte : bytes) { 123 for (const uint8_t byte : bytes) {
118 res += base::UintToString(byte); 124 res += base::UintToString(byte);
119 res += ", "; 125 res += ", ";
120 } 126 }
121 res += "])"; 127 res += "])";
122 return res; 128 return res;
123 } 129 }
124 130
131 // Enters the code in the ShowPinDialog window and pushes the OK event.
132 void EnterCode(chromeos::CertificateProviderService* service,
133 base::string16 code) {
134 chromeos::RequestPinView* view =
135 service->pin_dialog_manager()->active_view_for_testing();
136 view->textfield_for_testing()->SetText(code);
137 view->Accept();
138 base::RunLoop().RunUntilIdle();
139 }
140
141 // Enters the valid code for extensions from local example folders, in the
142 // ShowPinDialog window and waits for the window to close.
143 void EnterCorrectPin(chromeos::CertificateProviderService* service) {
144 views::Widget* active_window =
145 service->pin_dialog_manager()->active_window_for_testing();
146 EnterCode(service, base::ASCIIToUTF16("1234"));
147
148 // Wait for extension to send request to close the window.
149 while (!active_window->IsClosed()) {
150 base::RunLoop().RunUntilIdle();
151 }
152 }
153
154 // Enters an invalid code for extensions from local example folders, in the
155 // ShowPinDialog window and waits for the window to update with the error.
156 void EnterWrongPin(chromeos::CertificateProviderService* service) {
157 EnterCode(service, base::ASCIIToUTF16("123"));
158
159 chromeos::RequestPinView* view =
160 service->pin_dialog_manager()->active_view_for_testing();
161 // Waiting for extension to open the dialog again with an error in red
162 // displayed.
163 while (view->error_label_for_testing()->enabled_color() != SK_ColorRED) {
164 base::RunLoop().RunUntilIdle();
165 }
166 }
167
125 class CertificateProviderApiTest : public ExtensionApiTest { 168 class CertificateProviderApiTest : public ExtensionApiTest {
126 public: 169 public:
127 CertificateProviderApiTest() {} 170 CertificateProviderApiTest() {}
128 171
129 void SetUpInProcessBrowserTestFixture() override { 172 void SetUpInProcessBrowserTestFixture() override {
130 EXPECT_CALL(provider_, IsInitializationComplete(_)) 173 EXPECT_CALL(provider_, IsInitializationComplete(_))
131 .WillRepeatedly(Return(true)); 174 .WillRepeatedly(Return(true));
132 policy::BrowserPolicyConnector::SetPolicyProviderForTesting(&provider_); 175 policy::BrowserPolicyConnector::SetPolicyProviderForTesting(&provider_);
133 176
134 ExtensionApiTest::SetUpInProcessBrowserTestFixture(); 177 ExtensionApiTest::SetUpInProcessBrowserTestFixture();
(...skipping 11 matching lines...) Expand all
146 policy::PolicyMap policy; 189 policy::PolicyMap policy;
147 policy.Set(policy::key::kAutoSelectCertificateForUrls, 190 policy.Set(policy::key::kAutoSelectCertificateForUrls,
148 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER, 191 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
149 policy::POLICY_SOURCE_CLOUD, std::move(autoselect_policy), 192 policy::POLICY_SOURCE_CLOUD, std::move(autoselect_policy),
150 nullptr); 193 nullptr);
151 provider_.UpdateChromePolicy(policy); 194 provider_.UpdateChromePolicy(policy);
152 195
153 content::RunAllPendingInMessageLoop(); 196 content::RunAllPendingInMessageLoop();
154 } 197 }
155 198
199 // Loads certificate_provider extension from folder (the page basic.html).
200 // Returns the CertificateProviderService object from browser context.
201 chromeos::CertificateProviderService* LoadExtensionFromFolder(
202 std::string folder) {
203 content::WebContents* extension_contents =
204 browser()->tab_strip_model()->GetActiveWebContents();
205 chromeos::CertificateProviderService* service =
206 chromeos::CertificateProviderServiceFactory::GetForBrowserContext(
207 extension_contents->GetBrowserContext());
208 service->pin_dialog_manager()->AddSignRequestId(123);
209 const base::FilePath extension_path =
210 test_data_dir_.AppendASCII("certificate_provider/" + folder);
211 const extensions::Extension* const extension =
212 LoadExtension(extension_path);
213 ui_test_utils::NavigateToURL(browser(),
214 extension->GetResourceURL("basic.html"));
215 base::RunLoop().RunUntilIdle();
216 return service;
217 }
218
156 protected: 219 protected:
157 policy::MockConfigurationPolicyProvider provider_; 220 policy::MockConfigurationPolicyProvider provider_;
158 }; 221 };
159 222
160 } // namespace 223 } // namespace
161 224
162 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, Basic) { 225 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, Basic) {
163 // Start an HTTPS test server that requests a client certificate. 226 // Start an HTTPS test server that requests a client certificate.
164 net::SpawnedTestServer::SSLOptions ssl_options; 227 net::SpawnedTestServer::SSLOptions ssl_options;
165 ssl_options.request_client_certificate = true; 228 ssl_options.request_client_certificate = true;
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 base::RunLoop run_loop; 323 base::RunLoop run_loop;
261 const std::string code = "replyWithSignatureSecondTime();"; 324 const std::string code = "replyWithSignatureSecondTime();";
262 bool result = false; 325 bool result = false;
263 extension_contents->GetMainFrame()->ExecuteJavaScriptForTests( 326 extension_contents->GetMainFrame()->ExecuteJavaScriptForTests(
264 base::ASCIIToUTF16(code), 327 base::ASCIIToUTF16(code),
265 base::Bind(&StoreBool, &result, run_loop.QuitClosure())); 328 base::Bind(&StoreBool, &result, run_loop.QuitClosure()));
266 run_loop.Run(); 329 run_loop.Run();
267 EXPECT_TRUE(result); 330 EXPECT_TRUE(result);
268 } 331 }
269 } 332 }
333
334 // User closes the dialog three times, and the extension should be blocked from
335 // showing it again.
336 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, ShowPinDialogClose) {
337 chromeos::CertificateProviderService* service =
338 LoadExtensionFromFolder("request_pin");
339
340 views::Widget* window =
341 service->pin_dialog_manager()->active_window_for_testing();
342 for (int i = 0; i < extensions::MAX_CLOSED_DIALOGS_PER_10_MINUTES; i++) {
343 window->Close();
344 // Waiting for the new window to pop up.
345 while (service->pin_dialog_manager()->active_window_for_testing() ==
346 window) {
347 base::RunLoop().RunUntilIdle();
348 }
349
350 window = service->pin_dialog_manager()->active_window_for_testing();
351 }
352
353 // This time when closed, the window should not be able to pop up again.
354 window->Close();
355 EXPECT_EQ(service->pin_dialog_manager()->active_view_for_testing(), nullptr);
356 }
357
358 // User enters the correct PIN.
359 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, ShowPinDialogAccept) {
360 chromeos::CertificateProviderService* service =
361 LoadExtensionFromFolder("request_pin");
362
363 EnterCorrectPin(service);
364 chromeos::RequestPinView* view =
365 service->pin_dialog_manager()->active_view_for_testing();
366
367 // The view should be set to nullptr when the window is closed.
368 ASSERT_TRUE(view == nullptr);
369 }
370
371 // User enters a wrong PIN first and a correct PIN on the second try.
372 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, ShowPinDialogWrongPin) {
373 chromeos::CertificateProviderService* service =
374 LoadExtensionFromFolder("request_pin");
375
376 EnterWrongPin(service);
377 chromeos::RequestPinView* view =
378 service->pin_dialog_manager()->active_view_for_testing();
379
380 // The window should be active.
381 ASSERT_TRUE(
382 service->pin_dialog_manager()->active_window_for_testing()->IsVisible());
383 view = service->pin_dialog_manager()->active_view_for_testing();
384 ASSERT_TRUE(view != nullptr);
385
386 // Enter the valid PIN.
387 EnterCorrectPin(service);
388 view = service->pin_dialog_manager()->active_view_for_testing();
389
390 // The view should be set to nullptr when the window is closed.
391 ASSERT_TRUE(view == nullptr);
392 }
393
394 // User enters wrong PIN three times.
395 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest,
396 ShowPinDialogWrongPinThreeTimes) {
397 chromeos::CertificateProviderService* service =
398 LoadExtensionFromFolder("request_pin");
399 for (int i = 0; i < 3; i++) {
400 EnterWrongPin(service);
401 }
402
403 chromeos::RequestPinView* view =
404 service->pin_dialog_manager()->active_view_for_testing();
405
406 // The textfield has to be disabled, as extension does not allow input now.
407 ASSERT_FALSE(view->textfield_for_testing()->enabled());
408
409 // Close the dialog.
410 service->pin_dialog_manager()->active_window_for_testing()->Close();
411 EXPECT_EQ(service->pin_dialog_manager()->active_view_for_testing(), nullptr);
412 }
413
414 // User closes the dialog while the extension is processing the request.
415 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest,
416 ShowPinDialogCloseWhileProcessing) {
417 chromeos::CertificateProviderService* service =
418 LoadExtensionFromFolder("request_pin");
419
420 EnterCode(service, base::ASCIIToUTF16("123"));
421 service->pin_dialog_manager()->active_window_for_testing()->Close();
422
423 // The window should be active.
424 ASSERT_TRUE(
425 !service->pin_dialog_manager()->active_window_for_testing()->IsVisible());
426
427 // The view should be set to nullptr when the window is closed.
428 ASSERT_TRUE(
429 service->pin_dialog_manager()->active_view_for_testing() == nullptr);
430 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698