Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

Issue 2094333002: Implementation for chrome.certificateProvider.requestPin/stopPinRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Small fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <openssl/evp.h> 5 #include <openssl/evp.h>
6 #include <openssl/rsa.h> 6 #include <openssl/rsa.h>
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <stdlib.h> 9 #include <stdlib.h>
10 10
11 #include <memory> 11 #include <memory>
12 #include <string> 12 #include <string>
13 #include <vector> 13 #include <vector>
14 14
15 #include "base/bind.h" 15 #include "base/bind.h"
16 #include "base/callback.h" 16 #include "base/callback.h"
17 #include "base/files/file_path.h" 17 #include "base/files/file_path.h"
18 #include "base/files/file_util.h" 18 #include "base/files/file_util.h"
19 #include "base/run_loop.h" 19 #include "base/run_loop.h"
20 #include "base/strings/string_number_conversions.h" 20 #include "base/strings/string_number_conversions.h"
21 #include "base/strings/utf_string_conversions.h" 21 #include "base/strings/utf_string_conversions.h"
22 #include "base/values.h" 22 #include "base/values.h"
23 #include "chrome/browser/chromeos/certificate_provider/certificate_provider_serv ice.h"
24 #include "chrome/browser/chromeos/certificate_provider/certificate_provider_serv ice_factory.h"
25 #include "chrome/browser/extensions/api/certificate_provider/certificate_provide r_api.h"
23 #include "chrome/browser/extensions/extension_apitest.h" 26 #include "chrome/browser/extensions/extension_apitest.h"
24 #include "chrome/browser/ui/tabs/tab_strip_model.h" 27 #include "chrome/browser/ui/tabs/tab_strip_model.h"
25 #include "chrome/test/base/ui_test_utils.h" 28 #include "chrome/test/base/ui_test_utils.h"
26 #include "components/policy/core/browser/browser_policy_connector.h" 29 #include "components/policy/core/browser/browser_policy_connector.h"
27 #include "components/policy/core/common/mock_configuration_policy_provider.h" 30 #include "components/policy/core/common/mock_configuration_policy_provider.h"
28 #include "components/policy/core/common/policy_map.h" 31 #include "components/policy/core/common/policy_map.h"
29 #include "components/policy/core/common/policy_types.h" 32 #include "components/policy/core/common/policy_types.h"
30 #include "content/public/browser/render_frame_host.h" 33 #include "content/public/browser/render_frame_host.h"
31 #include "content/public/browser/web_contents.h" 34 #include "content/public/browser/web_contents.h"
32 #include "content/public/test/test_navigation_observer.h" 35 #include "content/public/test/test_navigation_observer.h"
33 #include "content/public/test/test_utils.h" 36 #include "content/public/test/test_utils.h"
34 #include "crypto/rsa_private_key.h" 37 #include "crypto/rsa_private_key.h"
35 #include "crypto/scoped_openssl_types.h" 38 #include "crypto/scoped_openssl_types.h"
36 #include "extensions/common/extension.h" 39 #include "extensions/common/extension.h"
37 #include "extensions/test/result_catcher.h" 40 #include "extensions/test/result_catcher.h"
38 #include "net/test/spawned_test_server/spawned_test_server.h" 41 #include "net/test/spawned_test_server/spawned_test_server.h"
39 #include "policy/policy_constants.h" 42 #include "policy/policy_constants.h"
40 #include "testing/gmock/include/gmock/gmock.h" 43 #include "testing/gmock/include/gmock/gmock.h"
44 #include "ui/views/controls/label.h"
45 #include "ui/views/controls/textfield/textfield.h"
46 #include "ui/views/widget/widget.h"
41 47
42 using testing::Return; 48 using testing::Return;
43 using testing::_; 49 using testing::_;
44 50
45 namespace { 51 namespace {
46 52
47 void IgnoreResult(const base::Closure& callback, const base::Value* value) { 53 void IgnoreResult(const base::Closure& callback, const base::Value* value) {
48 callback.Run(); 54 callback.Run();
49 } 55 }
50 56
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 std::string JsUint8Array(const std::vector<uint8_t>& bytes) { 121 std::string JsUint8Array(const std::vector<uint8_t>& bytes) {
116 std::string res = "new Uint8Array(["; 122 std::string res = "new Uint8Array([";
117 for (const uint8_t byte : bytes) { 123 for (const uint8_t byte : bytes) {
118 res += base::UintToString(byte); 124 res += base::UintToString(byte);
119 res += ", "; 125 res += ", ";
120 } 126 }
121 res += "])"; 127 res += "])";
122 return res; 128 return res;
123 } 129 }
124 130
131 // Enters the code in the ShowPinDialog window and pushes the OK event.
132 void EnterCode(chromeos::CertificateProviderService* service,
133 base::string16 code) {
134 chromeos::RequestPinView* view = service->active_view_for_testing();
135 view->textfield_for_testing()->SetText(code);
136 view->Accept();
137 }
138
139 // Enters the valid code for extensions from local example folders, in the
140 // ShowPinDialog window and waits for the window to close.
141 void EnterCorrectPin(chromeos::CertificateProviderService* service) {
142 EnterCode(service, base::ASCIIToUTF16("1234"));
143
144 // Wait for extension to send request to close the window.
145 while (!service->active_window_for_testing()->IsClosed()) {
146 base::RunLoop().RunUntilIdle();
147 }
148 }
149
150 // Enters an invalid code for extensions from local example folders, in the
151 // ShowPinDialog window and waits for the window to update with the error.
152 void EnterWrongPin(chromeos::CertificateProviderService* service) {
153 EnterCode(service, base::ASCIIToUTF16("123"));
154
155 chromeos::RequestPinView* view = service->active_view_for_testing();
156 // Waiting for extension to open the dialog again with an error in red
157 // displayed.
158 while (view->error_label_for_testing()->enabled_color() != SK_ColorRED) {
159 base::RunLoop().RunUntilIdle();
160 }
161 }
162
125 class CertificateProviderApiTest : public ExtensionApiTest { 163 class CertificateProviderApiTest : public ExtensionApiTest {
126 public: 164 public:
127 CertificateProviderApiTest() {} 165 CertificateProviderApiTest() {}
128 166
129 void SetUpInProcessBrowserTestFixture() override { 167 void SetUpInProcessBrowserTestFixture() override {
130 EXPECT_CALL(provider_, IsInitializationComplete(_)) 168 EXPECT_CALL(provider_, IsInitializationComplete(_))
131 .WillRepeatedly(Return(true)); 169 .WillRepeatedly(Return(true));
132 policy::BrowserPolicyConnector::SetPolicyProviderForTesting(&provider_); 170 policy::BrowserPolicyConnector::SetPolicyProviderForTesting(&provider_);
133 171
134 ExtensionApiTest::SetUpInProcessBrowserTestFixture(); 172 ExtensionApiTest::SetUpInProcessBrowserTestFixture();
(...skipping 11 matching lines...) Expand all
146 policy::PolicyMap policy; 184 policy::PolicyMap policy;
147 policy.Set(policy::key::kAutoSelectCertificateForUrls, 185 policy.Set(policy::key::kAutoSelectCertificateForUrls,
148 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER, 186 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
149 policy::POLICY_SOURCE_CLOUD, std::move(autoselect_policy), 187 policy::POLICY_SOURCE_CLOUD, std::move(autoselect_policy),
150 nullptr); 188 nullptr);
151 provider_.UpdateChromePolicy(policy); 189 provider_.UpdateChromePolicy(policy);
152 190
153 content::RunAllPendingInMessageLoop(); 191 content::RunAllPendingInMessageLoop();
154 } 192 }
155 193
194 // Loads certificate_provider extension from folder (the page basic.html).
195 // Returns the CertificateProviderService object from browser context.
196 chromeos::CertificateProviderService* LoadExtensionFromFolder(
197 std::string folder) {
198 const base::FilePath extension_path =
199 test_data_dir_.AppendASCII("certificate_provider/" + folder);
200 const extensions::Extension* const extension =
201 LoadExtension(extension_path);
202 ui_test_utils::NavigateToURL(browser(),
203 extension->GetResourceURL("basic.html"));
204 content::WebContents* extension_contents =
205 browser()->tab_strip_model()->GetActiveWebContents();
206 return
207 chromeos::CertificateProviderServiceFactory::GetForBrowserContext(
208 extension_contents->GetBrowserContext());
209 }
210
156 protected: 211 protected:
157 policy::MockConfigurationPolicyProvider provider_; 212 policy::MockConfigurationPolicyProvider provider_;
158 }; 213 };
159 214
160 } // namespace 215 } // namespace
161 216
162 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, Basic) { 217 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, Basic) {
163 // Start an HTTPS test server that requests a client certificate. 218 // Start an HTTPS test server that requests a client certificate.
164 net::SpawnedTestServer::SSLOptions ssl_options; 219 net::SpawnedTestServer::SSLOptions ssl_options;
165 ssl_options.request_client_certificate = true; 220 ssl_options.request_client_certificate = true;
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 base::RunLoop run_loop; 315 base::RunLoop run_loop;
261 const std::string code = "replyWithSignatureSecondTime();"; 316 const std::string code = "replyWithSignatureSecondTime();";
262 bool result = false; 317 bool result = false;
263 extension_contents->GetMainFrame()->ExecuteJavaScriptForTests( 318 extension_contents->GetMainFrame()->ExecuteJavaScriptForTests(
264 base::ASCIIToUTF16(code), 319 base::ASCIIToUTF16(code),
265 base::Bind(&StoreBool, &result, run_loop.QuitClosure())); 320 base::Bind(&StoreBool, &result, run_loop.QuitClosure()));
266 run_loop.Run(); 321 run_loop.Run();
267 EXPECT_TRUE(result); 322 EXPECT_TRUE(result);
268 } 323 }
269 } 324 }
325
326 // User closes the dialog three times, and the extension should be blocked from
327 // showing it again.
328 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, ShowPinDialogClose) {
329 chromeos::CertificateProviderService* service =
330 LoadExtensionFromFolder("show_pin_dialog");
331
332 views::Widget* window = service->active_window_for_testing();
333 for (int i = 0; i < extensions::MAX_CLOSED_DIALOGS_PER_10_MINUTES; i++) {
334 window->Close();
335 // Waiting for the new window to pop up.
336 while (service->active_window_for_testing() == window) {
337 base::RunLoop().RunUntilIdle();
338 }
339
340 window = service->active_window_for_testing();
341 }
342
343 // This time when closed, the window should not be able to pop up again.
344 window->Close();
345 EXPECT_EQ(service->active_view_for_testing(), nullptr);
346 }
347
348 // User enters the correct PIN.
349 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, ShowPinDialogAccept) {
350 chromeos::CertificateProviderService* service =
351 LoadExtensionFromFolder("show_pin_dialog");
352
353 EnterCorrectPin(service);
354 chromeos::RequestPinView* view = service->active_view_for_testing();
355
356 // The view should be set to nullptr when the window is closed.
357 ASSERT_TRUE(view == nullptr);
358 }
359
360 // User enters a wrong PIN first and a correct PIN on the second try.
361 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, ShowPinDialogWrongPin) {
362 chromeos::CertificateProviderService* service =
363 LoadExtensionFromFolder("show_pin_dialog");
364
365 EnterWrongPin(service);
366 chromeos::RequestPinView* view = service->active_view_for_testing();
367
368 // The window should be active.
369 ASSERT_TRUE(service->active_window_for_testing()->IsVisible());
370 view = service->active_view_for_testing();
371 ASSERT_TRUE(view != nullptr);
372
373 // Enter the valid PIN.
374 EnterCorrectPin(service);
375 view = service->active_view_for_testing();
376
377 // The view should be set to nullptr when the window is closed.
378 ASSERT_TRUE(view == nullptr);
379 }
380
381 // User enters wrong PIN three times.
382 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest,
383 ShowPinDialogWrongPinThreeTimes) {
384 chromeos::CertificateProviderService* service =
385 LoadExtensionFromFolder("show_pin_dialog");
386 for (int i = 0; i < 3; i++) {
387 EnterWrongPin(service);
388 }
389
390 chromeos::RequestPinView* view = service->active_view_for_testing();
391
392 // The textfield has to be disabled, as extension does not allow input now.
393 ASSERT_FALSE(view->textfield_for_testing()->enabled());
394
395 // Close the dialog.
396 service->active_window_for_testing()->Close();
397 EXPECT_EQ(service->active_view_for_testing(), nullptr);
398 }
399
400 // User closes the dialog while the extension is processing the request.
401 IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest,
402 ShowPinDialogCloseWhileProcessing) {
403 chromeos::CertificateProviderService* service =
404 LoadExtensionFromFolder("show_pin_dialog");
405
406 EnterCode(service, base::ASCIIToUTF16("123"));
407 service->active_window_for_testing()->Close();
408
409 // The window should be active.
410 ASSERT_TRUE(!service->active_window_for_testing()->IsVisible());
411
412 // The view should be set to nullptr when the window is closed.
413 ASSERT_TRUE(service->active_view_for_testing() == nullptr);
414 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698