Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 209433005: Use same icon set to be consistent in Files.app and Chrome (Closed)

Created:
6 years, 9 months ago by fukino
Modified:
6 years, 8 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use same icon set to be consistent in Files.app and Chrome. Make Files.app and Chrome refer same icon sets and remove duplicate files. Now those icon files are not under file_manager folder, changed their id from IDR_FILE_MANAGER_IMG_FILETYPE_* to IDR_FILETYPE_* BUG=343127 TEST=ran browser_test on Release/Debug. manually verified that each filetype icons appears correctly. R=jochen@chromium.org, oshima@chromium.org, yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261396

Patch Set 1 #

Patch Set 2 : fixed issue that some icons show normal icon instead of white icon #

Total comments: 92

Patch Set 3 : corrected indentation #

Patch Set 4 : Rebase onto head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -173 lines) Patch
M chrome/app/theme/default_100_percent/cros/file_types/archive.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/archive_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/audio.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/audio_white.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/chart.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/chart_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/excel.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/excel_white.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/folder.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/folder_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/form.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/form_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/gdoc.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/gdoc_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/gdraw.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/gdraw_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/generic.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/generic_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/glink.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/glink_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/gsheet.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/gsheet_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/gslides.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/gslides_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/gtable.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/gtable_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/image.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/image_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/pdf.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/pdf_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/ppt.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/ppt_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/script.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/script_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/sites.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/sites_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/video.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/video_white.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/cros/file_types/word.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/cros/file_types/word_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/archive.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/archive_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/audio.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/audio_white.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/chart.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/chart_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/excel.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/excel_white.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/folder.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/folder_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/form.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/form_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/gdoc.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/gdoc_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/gdraw.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/gdraw_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/generic.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/generic_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/glink.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/glink_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/gsheet.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/gsheet_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/gslides.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/gslides_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/gtable.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/gtable_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/image.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/image_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/pdf.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/pdf_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/ppt.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/ppt_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/script.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/script_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/sites.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/sites_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/video.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/video_white.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/cros/file_types/word.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/cros/file_types/word_white.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 3 1 chunk +44 lines, -24 lines 0 comments Download
M chrome/browser/icon_loader_chromeos.cc View 1 chunk +15 lines, -15 lines 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/archive.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/archive_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/audio.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/audio_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/chart.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/chart_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/excel.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/excel_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/folder.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/folder_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/form.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/form_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/gdoc.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/gdoc_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/gdraw.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/gdraw_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/generic.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/generic_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/glink.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/glink_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/gsheet.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/gsheet_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/gslides.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/gslides_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/gtable.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/gtable_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/image.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/image_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/pdf.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/pdf_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/ppt.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/ppt_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/script.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/script_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/sites.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/sites_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/video.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/video_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/word.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/100/word_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/archive.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/archive_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/audio.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/audio_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/chart.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/chart_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/excel.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/excel_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/folder.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/folder_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/form.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/form_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/gdoc.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/gdoc_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/gdraw.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/gdraw_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/generic.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/generic_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/glink.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/glink_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/gsheet.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/gsheet_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/gslides.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/gslides_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/gtable.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/gtable_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/image.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/image_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/pdf.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/pdf_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/ppt.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/ppt_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/script.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/script_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/sites.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/sites_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/video.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/video_white.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/word.png View Binary file 0 comments Download
D chrome/browser/resources/file_manager/common/images/file_types/200/word_white.png View Binary file 0 comments Download
M chrome/browser/resources/file_manager/foreground/css/file_types.css View 1 2 5 chunks +134 lines, -134 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
fukino
Yoshiki-san, Could you review my first patch?
6 years, 9 months ago (2014-03-25 03:51:49 UTC) #1
yoshiki
https://codereview.chromium.org/209433005/diff/20001/chrome/browser/resources/file_manager/foreground/css/file_types.css File chrome/browser/resources/file_manager/foreground/css/file_types.css (right): https://codereview.chromium.org/209433005/diff/20001/chrome/browser/resources/file_manager/foreground/css/file_types.css#newcode8 chrome/browser/resources/file_manager/foreground/css/file_types.css:8: url('chrome://theme/IDR_FILETYPE_GENERIC') 1x, Please fix the indent. We need four-space ...
6 years, 9 months ago (2014-03-25 04:04:06 UTC) #2
fukino
Yoshiki-san, Thank you for comments. I corrected indentation. Could you take a look? https://codereview.chromium.org/209433005/diff/20001/chrome/browser/resources/file_manager/foreground/css/file_types.css File ...
6 years, 9 months ago (2014-03-25 04:29:33 UTC) #3
fukino
Yoshiki-san, Thank you for comments. I corrected indentation. Could you take a look?
6 years, 9 months ago (2014-03-25 04:29:40 UTC) #4
yoshiki
On 2014/03/25 04:29:40, fukino wrote: > Yoshiki-san, > Thank you for comments. > I corrected ...
6 years, 9 months ago (2014-03-25 06:32:10 UTC) #5
fukino
Hi Oshima-san, I editid theme_resources.grd and moved some icon files from file_manager directory to theme ...
6 years, 9 months ago (2014-03-25 06:43:52 UTC) #6
fukino
ping @oshima san Though it may look like a big CL, almost all of them ...
6 years, 8 months ago (2014-03-31 00:48:56 UTC) #7
oshima
lgtm thank you for clean-up!
6 years, 8 months ago (2014-03-31 20:35:50 UTC) #8
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 8 months ago (2014-04-01 00:07:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/209433005/40001
6 years, 8 months ago (2014-04-01 00:08:46 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 00:09:52 UTC) #11
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/file_manager/video_player.html: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 8 months ago (2014-04-01 00:09:53 UTC) #12
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 8 months ago (2014-04-01 02:24:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/209433005/60001
6 years, 8 months ago (2014-04-01 02:25:45 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 03:07:36 UTC) #15
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58731
6 years, 8 months ago (2014-04-01 03:07:36 UTC) #16
fukino
Hi @jochen, I changed resource ID for file type icons icon_loader_chromeos.cc is affected. Could you ...
6 years, 8 months ago (2014-04-02 07:31:58 UTC) #17
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-02 09:23:36 UTC) #18
yoshiki
6 years, 8 months ago (2014-04-03 15:02:40 UTC) #19
Message was sent while issue was closed. 
Committed patchset #4 manually as r261396 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698