Source/core/xml/XPathParser.h - Issue 209433004: Do not zero-initialize RawPtr. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1236)

My Issues | Starred Open | Closed | All

Unified Diff: Source/core/xml/XPathParser.h

Issue 209433004: Do not zero-initialize RawPtr. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix compilation on gcc and msvc Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « Source/core/svg/SVGFontFaceSrcElement.cpp ('k') | Source/modules/webdatabase/DatabaseBackend.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/xml/XPathParser.h

diff --git a/Source/core/xml/XPathParser.h b/Source/core/xml/XPathParser.h

index 16d0fac05a7e61d2d69cfd015ddbaf56bb7dd017..7a28c1284e37e588d6dd7ed24efd7fcb8e4ada8c 100644

--- a/Source/core/xml/XPathParser.h

+++ b/Source/core/xml/XPathParser.h

@@ -64,8 +64,7 @@ struct Token {

class Parser {

WTF_MAKE_NONCOPYABLE(Parser);

- // FIXME: oilpan: This should be STACK_ALLOCATED.

- DISALLOW_ALLOCATION();

+ STACK_ALLOCATED();

public:

Parser();

~Parser();

@@ -122,7 +121,7 @@ private:

unsigned m_nextPos;

String m_data;

int m_lastTokenType;

- RefPtrWillBeRawPtr<XPathNSResolver> m_resolver;

+ RefPtrWillBeMember<XPathNSResolver> m_resolver;

HashSet<ParseNode*> m_parseNodes;

HashSet<Vector<OwnPtr<Predicate> >*> m_predicateVectors;

« no previous file with comments | « Source/core/svg/SVGFontFaceSrcElement.cpp ('k') | Source/modules/webdatabase/DatabaseBackend.cpp » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698