Source/core/css/CSSValuePool.cpp - Issue 209433004: Do not zero-initialize RawPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSValuePool.cpp

Issue 209433004: Do not zero-initialize RawPtr. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix compilation on gcc and msvc Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSValuePool.cpp

diff --git a/Source/core/css/CSSValuePool.cpp b/Source/core/css/CSSValuePool.cpp

index cfada987d0ee1121afdd62e116941a8088a2ec71..5fc50c765164cacb1fed3421897898b9fc425958 100644

--- a/Source/core/css/CSSValuePool.cpp

+++ b/Source/core/css/CSSValuePool.cpp

@@ -88,7 +88,7 @@ PassRefPtrWillBeRawPtr<CSSPrimitiveValue> CSSValuePool::createColorValue(unsigne

if (m_colorValueCache.size() > maximumColorCacheSize)

m_colorValueCache.clear();

- RefPtrWillBeRawPtr<CSSPrimitiveValue> dummyValue;

+ RefPtrWillBeRawPtr<CSSPrimitiveValue> dummyValue = nullptr;

ColorValueCache::AddResult entry = m_colorValueCache.add(rgbValue, dummyValue);

if (entry.isNewEntry)

entry.storedValue->value = CSSPrimitiveValue::createColor(rgbValue);

« no previous file with comments | « Source/core/css/CSSValueList.cpp ('k') | Source/core/css/ElementRuleCollector.cpp » ('j') | no next file with comments »