Source/core/frame/ImageBitmapTest.cpp - Issue 209433004: Do not zero-initialize RawPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/ImageBitmapTest.cpp

Issue 209433004: Do not zero-initialize RawPtr. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/ImageBitmapTest.cpp

diff --git a/Source/core/frame/ImageBitmapTest.cpp b/Source/core/frame/ImageBitmapTest.cpp

index d4633c8142f45636ce054da1ef7ab7d69bbb79b5..6e873fa180b625bd31a08e7a45715306c62a0906 100644

--- a/Source/core/frame/ImageBitmapTest.cpp

+++ b/Source/core/frame/ImageBitmapTest.cpp

@@ -210,7 +210,7 @@ TEST_F(ImageBitmapTest, ImageResourceLifetime)

RefPtr<HTMLCanvasElement> canvasElement = HTMLCanvasElement::create(*Document::create().get());

canvasElement->setHeight(40);

canvasElement->setWidth(40);

- RefPtrWillBeRawPtr<ImageBitmap> imageBitmapDerived;

+ RefPtrWillBeRawPtr<ImageBitmap> imageBitmapDerived = nullptr;

{

RefPtrWillBeRawPtr<ImageBitmap> imageBitmapFromCanvas = ImageBitmap::create(canvasElement.get(), IntRect(0, 0, canvasElement->width(), canvasElement->height()));

imageBitmapDerived = ImageBitmap::create(imageBitmapFromCanvas.get(), IntRect(0, 0, 20, 20));

« Source/core/css/parser/CSSPropertyParser.cpp ('K') | « Source/core/editing/EditingStyle.cpp ('k') | Source/core/page/EventHandler.cpp » ('j') | no next file with comments »