Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: Source/core/css/parser/BisonCSSParser-in.cpp

Issue 209433004: Do not zero-initialize RawPtr. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/parser/BisonCSSParser-in.cpp
diff --git a/Source/core/css/parser/BisonCSSParser-in.cpp b/Source/core/css/parser/BisonCSSParser-in.cpp
index 3034a6f41cc3808e7ef4cc3b532b8c67cd87aec7..bd5cdcd3459bdeca1707377a9f2ede3e5e2d6409 100644
--- a/Source/core/css/parser/BisonCSSParser-in.cpp
+++ b/Source/core/css/parser/BisonCSSParser-in.cpp
@@ -862,7 +862,7 @@ static bool parseKeywordValue(MutableStylePropertySet* declaration, CSSPropertyI
if (!valueID)
return false;
- RefPtrWillBeRawPtr<CSSValue> value;
+ RefPtrWillBeRawPtr<CSSValue> value = nullptr;
if (valueID == CSSValueInherit)
value = cssValuePool().createInheritedValue();
else if (valueID == CSSValueInitial)
@@ -947,7 +947,7 @@ static PassRefPtrWillBeRawPtr<CSSTransformValue> parseTranslateTransformValue(Ch
template <typename CharType>
static PassRefPtrWillBeRawPtr<CSSValueList> parseTranslateTransformList(CharType*& pos, CharType* end)
{
- RefPtrWillBeRawPtr<CSSValueList> transformList;
+ RefPtrWillBeRawPtr<CSSValueList> transformList = nullptr;
while (pos < end) {
while (pos < end && isCSSSpace(*pos))
++pos;
@@ -971,7 +971,7 @@ static bool parseTranslateTransform(MutableStylePropertySet* properties, CSSProp
return false;
if (string.isEmpty())
return false;
- RefPtrWillBeRawPtr<CSSValueList> transformList;
+ RefPtrWillBeRawPtr<CSSValueList> transformList = nullptr;
if (string.is8Bit()) {
const LChar* pos = string.characters8();
const LChar* end = pos + string.length();
@@ -1662,7 +1662,7 @@ StyleRuleBase* BisonCSSParser::createImportRule(const CSSParserString& url, Medi
StyleRuleBase* BisonCSSParser::createMediaRule(MediaQuerySet* media, RuleList* rules)
{
m_allowImportRules = m_allowNamespaceDeclarations = false;
- RefPtrWillBeRawPtr<StyleRuleMedia> rule;
+ RefPtrWillBeRawPtr<StyleRuleMedia> rule = nullptr;
if (rules) {
rule = StyleRuleMedia::create(media ? media : MediaQuerySet::create().get(), *rules);
} else {
@@ -1679,7 +1679,7 @@ StyleRuleBase* BisonCSSParser::createSupportsRule(bool conditionIsSupported, Rul
m_allowImportRules = m_allowNamespaceDeclarations = false;
RefPtr<CSSRuleSourceData> data = popSupportsRuleData();
- RefPtrWillBeRawPtr<StyleRuleSupports> rule;
+ RefPtrWillBeRawPtr<StyleRuleSupports> rule = nullptr;
String conditionText;
unsigned conditionOffset = data->ruleHeaderRange.start + 9;
unsigned conditionLength = data->ruleHeaderRange.length() - 9;

Powered by Google App Engine
This is Rietveld 408576698