Source/core/css/CSSBasicShapes.cpp - Issue 209433004: Do not zero-initialize RawPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSBasicShapes.cpp

Issue 209433004: Do not zero-initialize RawPtr. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSBasicShapes.cpp

diff --git a/Source/core/css/CSSBasicShapes.cpp b/Source/core/css/CSSBasicShapes.cpp

index fc0a2f2db1c40c791f375d8b62ef6b5cce62c7bb..876d8b684039194b935c69cf32148cd8ffc026fc 100644

--- a/Source/core/css/CSSBasicShapes.cpp

+++ b/Source/core/css/CSSBasicShapes.cpp

@@ -78,7 +78,7 @@ static String serializePositionOffset(const Pair& offset, const Pair& other)

static PassRefPtrWillBeRawPtr<CSSPrimitiveValue> buildSerializablePositionOffset(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> offset, CSSValueID defaultSide)

{

CSSValueID side = defaultSide;

- RefPtrWillBeRawPtr<CSSPrimitiveValue> amount;

+ RefPtrWillBeRawPtr<CSSPrimitiveValue> amount = nullptr;

if (!offset) {

side = CSSValueCenter;

« no previous file with comments | « Source/core/css/BasicShapeFunctions.cpp ('k') | Source/core/css/CSSCalculationValue.cpp » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')