Source/bindings/v8/V8Binding.cpp - Issue 209433004: Do not zero-initialize RawPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Binding.cpp

Issue 209433004: Do not zero-initialize RawPtr. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8Binding.cpp

diff --git a/Source/bindings/v8/V8Binding.cpp b/Source/bindings/v8/V8Binding.cpp

index 84d5c1e663aa0ffea86b20a6ff44db6a065e5c32..58b2e2394e1c5f8ff32db953c2e2ef42204c882e 100644

--- a/Source/bindings/v8/V8Binding.cpp

+++ b/Source/bindings/v8/V8Binding.cpp

@@ -460,7 +460,7 @@ float toFloat(v8::Handle<v8::Value> value, ExceptionState& exceptionState)

PassRefPtrWillBeRawPtr<XPathNSResolver> toXPathNSResolver(v8::Handle<v8::Value> value, v8::Isolate* isolate)

{

- RefPtrWillBeRawPtr<XPathNSResolver> resolver;

+ RefPtrWillBeRawPtr<XPathNSResolver> resolver = nullptr;

if (V8XPathNSResolver::hasInstance(value, isolate))

resolver = V8XPathNSResolver::toNative(v8::Handle<v8::Object>::Cast(value));

else if (value->IsObject())