Source/core/css/parser/CSSPropertyParser.h - Issue 209433004: Do not zero-initialize RawPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.h

Issue 209433004: Do not zero-initialize RawPtr. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix uses of RefPtrWillBeRawPtr Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSPropertyParser.h

diff --git a/Source/core/css/parser/CSSPropertyParser.h b/Source/core/css/parser/CSSPropertyParser.h

index f2bfb62d912ee9ac9d48a6219961796ede3f34c3..4df093ce51e6a1f87cab8b81a446fd68b3c7605b 100644

--- a/Source/core/css/parser/CSSPropertyParser.h

+++ b/Source/core/css/parser/CSSPropertyParser.h

@@ -382,7 +382,7 @@ private:

int m_inParseShorthand;

CSSPropertyID m_currentShorthand;

bool m_implicitShorthand;

- RefPtrWillBeRawPtr<CSSCalcValue> m_parsedCalculation;

+ RefPtrWillBeRawPtr<CSSCalcValue> m_parsedCalculation = nullptr;

haraken 2014/03/24 13:52:54 This object is stack-allocated. This could be a Re

Mads Ager (chromium) 2014/03/24 14:27:30 Yes, thanks. Done and I will merge with Ian's chan

// FIXME: There is probably a small set of APIs we could expose for these

// classes w/o needing to make them friends.