Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: Source/core/css/CSSCalculationValue.cpp

Issue 209433004: Do not zero-initialize RawPtr. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix uses of RefPtrWillBeRawPtr Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSCalculationValue.cpp
diff --git a/Source/core/css/CSSCalculationValue.cpp b/Source/core/css/CSSCalculationValue.cpp
index 03eefe953d70671b4986e3b9f11b08caeb4c4b4b..6914542ccb7f928ab74ed181f18f35cbf310ff59 100644
--- a/Source/core/css/CSSCalculationValue.cpp
+++ b/Source/core/css/CSSCalculationValue.cpp
@@ -559,7 +559,7 @@ private:
struct Value {
DISALLOW_ALLOCATION(); // Is only ever stack allocated.
haraken 2014/03/24 13:52:54 Can this be STACK_ALLOCATED() ?
Mads Ager (chromium) 2014/03/24 14:27:30 If the comments are true both this and CSSCalcExpr
public:
- RefPtrWillBeRawPtr<CSSCalcExpressionNode> value;
+ RefPtrWillBeRawPtr<CSSCalcExpressionNode> value = nullptr;
haraken 2014/03/24 13:52:54 Then this could be a RefPtrWillBeMember.
Mads Ager (chromium) 2014/03/24 14:27:30 Done.
};
char operatorValue(CSSParserValueList* tokens, unsigned index)
@@ -744,7 +744,7 @@ PassRefPtrWillBeRawPtr<CSSCalcExpressionNode> CSSCalcValue::createExpressionNode
PassRefPtrWillBeRawPtr<CSSCalcValue> CSSCalcValue::create(CSSParserString name, CSSParserValueList* parserValueList, ValueRange range)
{
CSSCalcExpressionNodeParser parser;
- RefPtrWillBeRawPtr<CSSCalcExpressionNode> expression;
+ RefPtrWillBeRawPtr<CSSCalcExpressionNode> expression = nullptr;
if (equalIgnoringCase(name, "calc(") || equalIgnoringCase(name, "-webkit-calc("))
expression = parser.parseCalc(parserValueList);

Powered by Google App Engine
This is Rietveld 408576698