Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: Source/core/page/EventHandler.cpp

Issue 209433004: Do not zero-initialize RawPtr. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix uses of RefPtrWillBeRawPtr Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 3 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
4 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies) 4 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 3572 matching lines...) Expand 10 before | Expand all | Expand 10 after
3583 // Holds the complete set of touches on the screen and will be used as the ' touches' list in the JS event. 3583 // Holds the complete set of touches on the screen and will be used as the ' touches' list in the JS event.
3584 RefPtrWillBeRawPtr<TouchList> touches = TouchList::create(); 3584 RefPtrWillBeRawPtr<TouchList> touches = TouchList::create();
3585 3585
3586 // A different view on the 'touches' list above, filtered and grouped by eve nt target. Used for the 3586 // A different view on the 'touches' list above, filtered and grouped by eve nt target. Used for the
3587 // 'targetTouches' list in the JS event. 3587 // 'targetTouches' list in the JS event.
3588 typedef WillBeHeapHashMap<EventTarget*, RefPtrWillBeMember<TouchList> > Targ etTouchesHeapMap; 3588 typedef WillBeHeapHashMap<EventTarget*, RefPtrWillBeMember<TouchList> > Targ etTouchesHeapMap;
3589 TargetTouchesHeapMap touchesByTarget; 3589 TargetTouchesHeapMap touchesByTarget;
3590 3590
3591 // Array of touches per state, used to assemble the 'changedTouches' list in the JS event. 3591 // Array of touches per state, used to assemble the 'changedTouches' list in the JS event.
3592 typedef HashSet<RefPtr<EventTarget> > EventTargetSet; 3592 typedef HashSet<RefPtr<EventTarget> > EventTargetSet;
3593 struct { 3593 struct {
haraken 2014/03/24 13:52:54 Won't this be stack-allocated as well?
Mads Ager (chromium) 2014/03/24 14:27:30 Yes it will. I'm not sure what the plugin will say
3594 // The touches corresponding to the particular change state this struct instance represents. 3594 // The touches corresponding to the particular change state this struct instance represents.
3595 RefPtrWillBeRawPtr<TouchList> m_touches; 3595 RefPtrWillBeRawPtr<TouchList> m_touches = nullptr;
3596 // Set of targets involved in m_touches. 3596 // Set of targets involved in m_touches.
3597 EventTargetSet m_targets; 3597 EventTargetSet m_targets;
3598 } changedTouches[PlatformTouchPoint::TouchStateEnd]; 3598 } changedTouches[PlatformTouchPoint::TouchStateEnd];
3599 3599
3600 const Vector<PlatformTouchPoint>& points = event.touchPoints(); 3600 const Vector<PlatformTouchPoint>& points = event.touchPoints();
3601 3601
3602 UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture); 3602 UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
3603 3603
3604 unsigned i; 3604 unsigned i;
3605 bool freshTouchEvents = true; 3605 bool freshTouchEvents = true;
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
4024 unsigned EventHandler::accessKeyModifiers() 4024 unsigned EventHandler::accessKeyModifiers()
4025 { 4025 {
4026 #if OS(MACOSX) 4026 #if OS(MACOSX)
4027 return PlatformEvent::CtrlKey | PlatformEvent::AltKey; 4027 return PlatformEvent::CtrlKey | PlatformEvent::AltKey;
4028 #else 4028 #else
4029 return PlatformEvent::AltKey; 4029 return PlatformEvent::AltKey;
4030 #endif 4030 #endif
4031 } 4031 }
4032 4032
4033 } // namespace WebCore 4033 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698