Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: content/renderer/input/input_event_filter.h

Issue 2094323002: Ensure acks are sent for all blocking events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/input_event_filter.h
diff --git a/content/renderer/input/input_event_filter.h b/content/renderer/input/input_event_filter.h
index 3a953fd9180e7f1cef9d244d46c1625b80e16c33..07ccfe026bc9e1636fdeeaeed9628a8cf0d50183 100644
--- a/content/renderer/input/input_event_filter.h
+++ b/content/renderer/input/input_event_filter.h
@@ -68,7 +68,8 @@ class CONTENT_EXPORT InputEventFilter : public InputHandlerManagerClient,
void DidStartFlinging(int routing_id) override;
void DidStopFlinging(int routing_id) override;
void NotifyInputEventHandled(int routing_id,
- blink::WebInputEvent::Type type) override;
+ blink::WebInputEvent::Type type,
+ InputEventAckState ack_result) override;
// IPC::MessageFilter methods:
void OnFilterAdded(IPC::Sender* sender) override;
@@ -81,6 +82,13 @@ class CONTENT_EXPORT InputEventFilter : public InputHandlerManagerClient,
const blink::WebInputEvent* event,
const ui::LatencyInfo& latency,
InputEventDispatchType dispatch_type) override;
+ // Send an InputEventAck IPC message. |touch_event_id| represents
+ // the unique event id for the original WebTouchEvent and should
+ // represent 0; otherewise. See WebInputEventTraits::GetUniqueTouchEventId.
tdresser 2016/06/28 17:59:24 and should be 0 if... It isn't clear what otherwi
dtapuska 2016/06/28 19:51:08 Done.
+ void SendInputEventAck(int routing_id,
+ blink::WebInputEvent::Type type,
+ InputEventAckState ack_result,
+ uint32_t touch_event_id) override;
private:
~InputEventFilter() override;
« no previous file with comments | « no previous file | content/renderer/input/input_event_filter.cc » ('j') | content/renderer/input/main_thread_event_queue.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698