Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: content/renderer/input/render_widget_input_handler_delegate.h

Issue 2094323002: Ensure acks are sent for all blocking events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_ 5 #ifndef CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_
6 #define CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_ 6 #define CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 // Notifies that an overscroll was completed from Blink. 56 // Notifies that an overscroll was completed from Blink.
57 virtual void OnDidOverscroll(const DidOverscrollParams& params) = 0; 57 virtual void OnDidOverscroll(const DidOverscrollParams& params) = 0;
58 58
59 // Called when an ACK is ready to be sent to the input event provider. 59 // Called when an ACK is ready to be sent to the input event provider.
60 virtual void OnInputEventAck( 60 virtual void OnInputEventAck(
61 std::unique_ptr<InputEventAck> input_event_ack) = 0; 61 std::unique_ptr<InputEventAck> input_event_ack) = 0;
62 62
63 // Called when an event with a notify dispatch type 63 // Called when an event with a notify dispatch type
64 // (DISPATCH_TYPE_*_NOTIFY_MAIN) of |handled_type| has been processed 64 // (DISPATCH_TYPE_*_NOTIFY_MAIN) of |handled_type| has been processed
65 // by the main thread. 65 // by the main thread.
66 virtual void NotifyInputEventHandled( 66 virtual void NotifyInputEventHandled(blink::WebInputEvent::Type handled_type,
67 blink::WebInputEvent::Type handled_type) = 0; 67 InputEventAckState ack_result) = 0;
68 68
69 // Notifies the delegate of the |input_handler| managing it. 69 // Notifies the delegate of the |input_handler| managing it.
70 virtual void SetInputHandler(RenderWidgetInputHandler* input_handler) = 0; 70 virtual void SetInputHandler(RenderWidgetInputHandler* input_handler) = 0;
71 71
72 // |show_ime| should be ShowIme::IF_NEEDED iff the update may cause the ime to 72 // |show_ime| should be ShowIme::IF_NEEDED iff the update may cause the ime to
73 // be displayed, e.g. after a tap on an input field on mobile. 73 // be displayed, e.g. after a tap on an input field on mobile.
74 // |change_source| should be ChangeSource::FROM_NON_IME when the renderer has 74 // |change_source| should be ChangeSource::FROM_NON_IME when the renderer has
75 // to wait for the browser to acknowledge the change before the renderer 75 // to wait for the browser to acknowledge the change before the renderer
76 // handles any more IME events. This is when the text change did not originate 76 // handles any more IME events. This is when the text change did not originate
77 // from the IME in the browser side, such as changes by JavaScript or 77 // from the IME in the browser side, such as changes by JavaScript or
(...skipping 11 matching lines...) Expand all
89 // won't be sent to WebKit or trigger DidHandleMouseEvent(). 89 // won't be sent to WebKit or trigger DidHandleMouseEvent().
90 virtual bool WillHandleMouseEvent(const blink::WebMouseEvent& event) = 0; 90 virtual bool WillHandleMouseEvent(const blink::WebMouseEvent& event) = 0;
91 91
92 protected: 92 protected:
93 virtual ~RenderWidgetInputHandlerDelegate() {} 93 virtual ~RenderWidgetInputHandlerDelegate() {}
94 }; 94 };
95 95
96 } // namespace content 96 } // namespace content
97 97
98 #endif // CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_ 98 #endif // CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698