Fix behavior of throw on yield*.

Fix behavior of throw on yield*.

When calling the throw method on a generator suspended inside a yield*, yield*
in turn tries to call throw on its iterable.  If the iterable does not provide a
throw method, yield* must try to call the return method instead and then throw a
TypeError.  Due to a bug in our desugaring, we never threw the TypeError.

R=adamk@chromium.org
BUG=v8:5132
Committed: https://crrev.com/2f0cb3afa350c5c0a85f6cdb34aad402afb6ff50
Cr-Commit-Position: refs/heads/master@{#37314}

[neis, 2016-06-27 10:43:58]

Patchset #1 (id:1) has been deleted

[neis, 2016-06-27 10:44:04]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 10:44:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-06-27 10:56:14]

Description was changed from

==========
Fix behavior of throw on yield*.

When calling the throw method on a generator suspended inside a yield*, yield*
in turn tries to call throw on its iterable.  If the iterable does not provide a
throw method, yield* must try to call the return method instead and then throw a
TypeError.  Due to a bug in our desugaring, we never threw the TypeError.

BUG=v8:5132
==========

to

==========
Fix behavior of throw on yield*.

When calling the throw method on a generator suspended inside a yield*, yield*
in turn tries to call throw on its iterable.  If the iterable does not provide a
throw method, yield* must try to call the return method instead and then throw a
TypeError.  Due to a bug in our desugaring, we never threw the TypeError.

R=adamk@chromium.org
BUG=v8:5132
==========

[neis, 2016-06-27 10:56:14]

neis@chromium.org changed reviewers:
+ adamk@chromium.org

[neis, 2016-06-27 11:03:34]

ptal

[commit-bot: I haz the power, 2016-06-27 11:10:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 11:10:08]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-06-27 18:21:45]

lgtm

[neis, 2016-06-28 07:09:46]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-06-28 07:09:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 07:12:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 07:12:15]

Failed to apply patch for test/mjsunit/harmony/generators-turbo.js:
While running git apply --index -3 -p1;
  error: patch failed: test/mjsunit/harmony/generators-turbo.js:643
  Falling back to three-way merge...
  Applied patch to 'test/mjsunit/harmony/generators-turbo.js' with conflicts.
  U test/mjsunit/harmony/generators-turbo.js

Patch:       test/mjsunit/harmony/generators-turbo.js
Index: test/mjsunit/harmony/generators-turbo.js
diff --git a/test/mjsunit/harmony/generators-turbo.js
b/test/mjsunit/harmony/generators-turbo.js
index
d12c8cffe1aae50ef5830aafe585d88d257d7ae5..ed0b9b0d572bb1a342d39390a8ec48cdb3031552
100644
--- a/test/mjsunit/harmony/generators-turbo.js
+++ b/test/mjsunit/harmony/generators-turbo.js
@@ -643,3 +643,15 @@ function Throw(generator, ...args) {
   assertEquals({value: 42, done: false}, Next(g));
   assertEquals({value: 42, done: false}, Next(g));
 }
+
+{
+  let iterable = {
+    [Symbol.iterator]() {
+      return { next() { return {} } };
+    }
+  };
+  let foo = function*() { yield* iterable };
+  g = foo();
+  g.next();
+  assertThrows(() => Throw(g), TypeError);
+}

[neis, 2016-06-28 07:16:11]

The CQ bit was checked by neis@chromium.org

[neis, 2016-06-28 07:16:11]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2094253002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-28 07:16:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 07:43:45]

Description was changed from

==========
Fix behavior of throw on yield*.

When calling the throw method on a generator suspended inside a yield*, yield*
in turn tries to call throw on its iterable.  If the iterable does not provide a
throw method, yield* must try to call the return method instead and then throw a
TypeError.  Due to a bug in our desugaring, we never threw the TypeError.

R=adamk@chromium.org
BUG=v8:5132
==========

to

==========
Fix behavior of throw on yield*.

When calling the throw method on a generator suspended inside a yield*, yield*
in turn tries to call throw on its iterable.  If the iterable does not provide a
throw method, yield* must try to call the return method instead and then throw a
TypeError.  Due to a bug in our desugaring, we never threw the TypeError.

R=adamk@chromium.org
BUG=v8:5132
==========

[commit-bot: I haz the power, 2016-06-28 07:43:46]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-28 07:46:20]

Description was changed from

==========
Fix behavior of throw on yield*.

When calling the throw method on a generator suspended inside a yield*, yield*
in turn tries to call throw on its iterable.  If the iterable does not provide a
throw method, yield* must try to call the return method instead and then throw a
TypeError.  Due to a bug in our desugaring, we never threw the TypeError.

R=adamk@chromium.org
BUG=v8:5132
==========

to

==========
Fix behavior of throw on yield*.

When calling the throw method on a generator suspended inside a yield*, yield*
in turn tries to call throw on its iterable.  If the iterable does not provide a
throw method, yield* must try to call the return method instead and then throw a
TypeError.  Due to a bug in our desugaring, we never threw the TypeError.

R=adamk@chromium.org
BUG=v8:5132

Committed: https://crrev.com/2f0cb3afa350c5c0a85f6cdb34aad402afb6ff50
Cr-Commit-Position: refs/heads/master@{#37314}
==========

[commit-bot: I haz the power, 2016-06-28 07:46:21]

Patchset 2 (id:??) landed as
https://crrev.com/2f0cb3afa350c5c0a85f6cdb34aad402afb6ff50
Cr-Commit-Position: refs/heads/master@{#37314}